Detect benchmarks as tests in engine repo#1392
Merged
fluttergithubbot merged 2 commits intoflutter:mainfrom Oct 13, 2021
Merged
Detect benchmarks as tests in engine repo#1392fluttergithubbot merged 2 commits intoflutter:mainfrom
fluttergithubbot merged 2 commits intoflutter:mainfrom
Conversation
keyonghan
approved these changes
Oct 13, 2021
Contributor
keyonghan
left a comment
keyonghan
left a comment
There was a problem hiding this comment.
LGTM with tests passing.
Contributor
Author
|
Whups - fixed the regex. It needed to be |
dnfield
added
the
waiting for tree to go green
|
I think we should revert this because... a benchmark is not a test. While the benchmark may exercise code newly added or modified along the way. How fast something is orthogonal to its correctness. |
Contributor
Author
|
But some changes are only covered by benchmarks right? |
Contributor
Author
|
My particular change may need a different test, but it seems fair to leave it to reviewers rather than the bot whether a particular change needs a benchmark or unit test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engine uses things like shell_benchmarks.cc for benchmark related tests.
@xster fyi
Another attempt here, this time starting witht he right base.