Skip to content

Adds additional mock to test to unskip flaky bot tests#1579

Merged
fluttergithubbot merged 3 commits intoflutter:mainfrom
chunhtai:issues/90139
Feb 2, 2022
Merged

Adds additional mock to test to unskip flaky bot tests#1579
fluttergithubbot merged 3 commits intoflutter:mainfrom
chunhtai:issues/90139

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Feb 2, 2022

fixes flutter/flutter#90139

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai requested a review from keyonghan February 2, 2022 21:35
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!!

@chunhtai chunhtai added the waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot label Feb 2, 2022
@fluttergithubbot fluttergithubbot merged commit 3226b69 into flutter:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cocoon] Migrate flaky issue bot to null safety

3 participants