do not require tests for whitespace only changes#2780
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom May 19, 2023
christopherfujino:dont-require-tests-for-whitespace
Merged
do not require tests for whitespace only changes#2780auto-submit[bot] merged 2 commits intoflutter:mainfrom christopherfujino:dont-require-tests-for-whitespace
auto-submit[bot] merged 2 commits intoflutter:mainfrom
christopherfujino:dont-require-tests-for-whitespace
Conversation
hellohuanlin
approved these changes
May 19, 2023
hellohuanlin
left a comment
hellohuanlin
left a comment
There was a problem hiding this comment.
is this only for the engine? what about the framework?
app_dart/lib/src/request_handlers/github/webhook_subscription.dart
Outdated
Show resolved
Hide resolved
Contributor
Author
I could add another test, but the same code runs regardless of the repo |
stuartmorgan-g
approved these changes
May 19, 2023
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Thanks for cleaning up my mistake 🙂
christopherfujino
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See for example this change that only touches comments and whitespace: flutter/flutter#127227