Skip to content

Updated dashboard/test/widgets tests to handle useMaterial3:true by default#2846

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
HansMuller:update_golden_image_tests_for_m3
Jun 15, 2023
Merged

Updated dashboard/test/widgets tests to handle useMaterial3:true by default#2846
auto-submit[bot] merged 1 commit intoflutter:mainfrom
HansMuller:update_golden_image_tests_for_m3

Conversation

@HansMuller
Copy link
Contributor

Updated all of the golden image file tests in dashboard/test/widgets to specify useMaterial3: false to ensure that the images continue to match when the default for useMaterial3 is changed to true.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App. label Jun 15, 2023
@auto-submit auto-submit bot merged commit a985c57 into flutter:main Jun 15, 2023
@HansMuller HansMuller deleted the update_golden_image_tests_for_m3 branch June 15, 2023 16:58
HansMuller added a commit to flutter/tests that referenced this pull request Jun 15, 2023
Updated the cocoon hash to bring in golden image test changes that will
allow ThemeData.useMaterial3's default to become true. See
flutter/cocoon#2846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants