Skip to content

Replace an NPE with a human-readable error message.#3831

Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom
matanlurey:make-test-owners-error-human-readable
Jul 24, 2024
Merged

Replace an NPE with a human-readable error message.#3831
auto-submit[bot] merged 3 commits intoflutter:mainfrom
matanlurey:make-test-owners-error-human-readable

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Jul 24, 2024

See flutter/flutter#152194 where I got befuddling error messages:

Unhandled exception:
Null check operator used on a null value
#0      DeviceLabTestOwner.getTestOwnership (package:cocoon_service/src/request_handlers/test_ownership.dart:60:59)
#1      getTestOwnership (package:cocoon_service/src/request_handlers/flaky_handler_utils.dart:301:20)
#2      validateOwnership (package:cocoon_service/src/foundation/utils.dart:225:27)
#3      remoteCheck (file:///b/s/w/ir/x/w/cocoon/app_dart/bin/validate_task_ownership.dart:31:40)
<asynchronous suspension>
#4      main (file:///b/s/w/ir/x/w/cocoon/app_dart/bin/validate_task_ownership.dart:63:23)
<asynchronous suspension>

@reidbaker reidbaker self-requested a review July 24, 2024 17:37
reidbaker
reidbaker approved these changes Jul 24, 2024
View reviewed changes
app_dart/lib/src/request_handlers/test_ownership.dart Outdated
'.ci.yaml target is missing this field *OR* the target was not '
'intended to run in the device lab, and "devicelab" should be removed '
'from the "tags" field.\n\n'
'See <https://github.com/flutter/cocoon/blob/637bca4ded99ca704376fbf2c8558cf15140e8ca/CI_YAML.md> '
Copy link
Contributor

@reidbaker reidbaker Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to link to a hash instead of https://github.com/flutter/cocoon/blob/main/CI_YAML.md?

Copy link
Contributor Author

@matanlurey matanlurey Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App. label Jul 24, 2024
@auto-submit auto-submit bot merged commit 6239d77 into flutter:main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matanlurey @reidbaker