Draft Support with light cleaning#413
Merged
Piinks merged 14 commits intoflutter:masterfrom Sep 13, 2019
Merged
Conversation
Piinks
changed the title
dnfield
previously approved these changes
Sep 12, 2019
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM - thanks for splitting this out
Contributor
Author
|
Do not merge. CI is lying, tests are currently failing. |
Contributor
Author
|
TIL commit messages don't distinguish between ", ', and ` |
Piinks
dismissed
dnfield’s stale review
CI is failing but showing green, dismissing to prevent accidental merge. :)
Contributor
|
Can you rebase against master and try this again? Maybe with a failing test too so we can see CI go red? hah |
Contributor
|
(Don't worry about a failing test - pretty sure the problem is fixed, a failing test will make CI red now) |
Contributor
Author
|
cc/ @dnfield this is cleaned up and passing all tests now, PTAL. :) |
dnfield
approved these changes
Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opened,reopened, +ready_for_review, +edited