Always set FLUTTER_PREBUILT_ENGINE_VERSION for framework-stage PRs.#4254
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Feb 25, 2025
Conversation
2 tasks
reidbaker
approved these changes
Feb 25, 2025
| checkRunGuard: '$lock', | ||
| logCrumb: logCrumb, | ||
|
|
||
| // The if-branch already skips the engine build phase. |
Contributor
There was a problem hiding this comment.
Is the branch you are talking about here this one -> isFusion && await _applyFrameworkOnlyPrOptimization(
jason-simmons
added a commit
to jason-simmons/flutter_cocoon
that referenced
this pull request
Feb 25, 2025
…age PRs. (flutter#4254)" This reverts commit fc543f1. This is causing errors when presubmit CI jobs try to download the Dart SDK from a URL that is missing the "flutter_archives_v2" realm.
matanlurey
added a commit
to matanlurey/cocoon
that referenced
this pull request
Feb 25, 2025
…ework-stage PRs. (flutter#4254)" (flutter#4259)" This reverts commit 60a4a71.
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
…INE_VERSION` from framework tests) (#4261) Closes flutter/flutter#164031.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes flutter/flutter#164031.