Skip to content

Always set FLUTTER_PREBUILT_ENGINE_VERSION for framework-stage PRs.#4254

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
matanlurey:always-set-flutter-prebuilt-engine-for-framework-prs
Feb 25, 2025
Merged

Always set FLUTTER_PREBUILT_ENGINE_VERSION for framework-stage PRs.#4254
auto-submit[bot] merged 2 commits intoflutter:mainfrom
matanlurey:always-set-flutter-prebuilt-engine-for-framework-prs

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey requested a review from jtmcdole February 25, 2025 02:33
checkRunGuard: '$lock',
logCrumb: logCrumb,

// The if-branch already skips the engine build phase.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the branch you are talking about here this one -> isFusion && await _applyFrameworkOnlyPrOptimization(

Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App. label Feb 25, 2025
@auto-submit auto-submit bot merged commit fc543f1 into flutter:main Feb 25, 2025
4 checks passed
jason-simmons added a commit to jason-simmons/flutter_cocoon that referenced this pull request Feb 25, 2025
…age PRs. (flutter#4254)"

This reverts commit fc543f1.

This is causing errors when presubmit CI jobs try to download the Dart SDK from a URL that is missing the "flutter_archives_v2" realm.
auto-submit bot pushed a commit that referenced this pull request Feb 25, 2025
…age PRs. (#4254)" (#4259)

This reverts commit fc543f1.

This is causing errors when presubmit CI jobs try to download the Dart SDK from a URL that is missing the "flutter_archives_v2" realm.
matanlurey added a commit to matanlurey/cocoon that referenced this pull request Feb 25, 2025
auto-submit bot pushed a commit that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Cocoon to always pass FLUTTER_PREBUILT_ENGINE_VERSION

3 participants