Rerun prod task cleanup, stop using keys, support task: "all".#4328
Merged
auto-submit[bot] merged 4 commits intoflutter:mainfrom Mar 12, 2025
Merged
Rerun prod task cleanup, stop using keys, support task: "all".#4328auto-submit[bot] merged 4 commits intoflutter:mainfrom
task: "all".#4328auto-submit[bot] merged 4 commits intoflutter:mainfrom
Conversation
jtmcdole
approved these changes
Mar 12, 2025
Comment on lines
+69
to
+74
| final { | ||
| _paramBranch: String branch, | ||
| _paramRepo: String repo, | ||
| _paramCommitSha: String commitSha, | ||
| _paramTaskName: String taskName, | ||
| } = requestData!; |
Contributor
Author
|
Good luck (to me). |
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/cocoon/4328, because Pull request flutter/cocoon/4328 is not in a mergeable state. |
matanlurey
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#164032.
Closes flutter/flutter#165058.
Summary of changes:
/api/reset-prod-taskto/api/rerun-prod-taskfor naming clarity (including on the frontend)/api/v2/reset-prod-task)commitKey(easier to migrate from datastore to firestore)task: all) to support the "run all tasks for the given commit" (for release branches)Footnotes
Maybe we could get just a get away with task+commit? Wdut @jtmcdole? ↩