Performance Improvement for Gold Check#672
Conversation
| lastUpdate.head == pr.head.sha) { | ||
| log.debug('Completed status already reported for this commit.'); | ||
| // We have already seen this commit and it is completed. | ||
| continue; |
There was a problem hiding this comment.
This is the case for an overwhelming number of PRs.
|
I have added a few more changes after touching base with @kjlubick about the amount of traffic on the gold endpoint PTAL. :) |
|
I have to fix the formatting, but oddly dartfmt is different on my laptop. 😖 |
| final List<dynamic> cirrusChecks = | ||
| await queryCirrusGraphQL(pr.head.sha, cirrusClient, log, 'flutter'); | ||
| for (dynamic check in cirrusChecks) { | ||
| final String status = check['status']; | ||
| final String taskName = check['name']; |
There was a problem hiding this comment.
This is reminding me that we should turn off avoid_as and set implicit-casts: false.
I was going to suggest some ways to avoid dynamic typing here but we can save that for a PR that just changes those lints around.
app_dart/lib/src/request_handlers/push_gold_status_to_github.dart
Outdated
Show resolved
Hide resolved
|
This is all fixed now. Sorry for the noise. :) |
3 participants
Uh oh!
There was an error while loading. Please reload this page.