Workaround fix for performance benchmarks dashboard with limited data#689
Conversation
| // Queries for recent commits without considering branches. | ||
| // TODO(keyonghan): combine this function with the above `queryRecentCommits`, | ||
| // this needs to fix https://github.com/flutter/flutter/issues/52694. | ||
| Stream<Commit> queryRecentCommitsNoBranch({int limit = 100, int timestamp}) { |
There was a problem hiding this comment.
Are 100 commits enough? I remember that @CaseyHillers or @digiter once extended the memcache from 3 months of commits to 6 months of commits to properly triage some performance issues. If there are 10 commits a day, that's a limit of 1800 commits.
There was a problem hiding this comment.
That's the default number for this function. The actual limit for history API is 6000.
There was a problem hiding this comment.
To clarify, the issue @liyuqian : There was an update to the Datastore records to use a new index for the branching release strategy in Flutter. This an unintended side effect as Cocoon never saved previous records with a branch until the past few weeks. This adds a new query that doesn't use the branch field (at the moment there are very few timeseries datapoints that will impact the perf graphs).
The long term solution is going to be to update old timeseries data to have a master branch (as Cocoon only processed data on master before).
There was a problem hiding this comment.
Thanks @CaseyHillers for the explanation. And thank you @keyonghan for a quick fix!
CaseyHillers
left a comment
CaseyHillers
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the quick fix and adding a link to the GitHub issue so we remember to remove this once the branch field gets updated on older data.
|
Shall I merge it now? Is there any extra step to get the fix deployed? |
|
@liyuqian there's some issues in Flutter dev that created issues for the Cocoon project where it can't be deployed. Keyong is working on resolving them first. |
|
@liyuqian Just deployed. You should be able to see the data now. |
3 participants
This fixes: flutter/flutter#52692