Explicitly use the master branch in build dashboard#693
Merged
CaseyHillers merged 5 commits intoflutter:masterfrom Mar 18, 2020
Merged
Explicitly use the master branch in build dashboard#693CaseyHillers merged 5 commits intoflutter:masterfrom
CaseyHillers merged 5 commits intoflutter:masterfrom
Conversation
19 tasks
CaseyHillers
force-pushed
the
master_branch
branch
from
e014f6b to
d0f7028
Compare
CaseyHillers
changed the title
digiter
approved these changes
Mar 18, 2020
Contributor
digiter
left a comment
digiter
left a comment
There was a problem hiding this comment.
LGTM with nit: it seems there's no test with branch name other than "master", consider adding one?
keyonghan
reviewed
Mar 18, 2020
Fix nesting of a group within a group
Contributor
Author
|
Added the test for specific branches. Good catch! Fixed some groups that were nested in another group. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create
currentBranchinFlutterBuildStateand plumbed it through everywhere that uses it.Refactored some of the test code to remove some of the duplication spread throughout it and fixed some spacing issues.
Tests
Added tests for
apiEndpointrefactor to handle query parameters.Updated tests to check for defaulting to the
masterbranch.Issues
flutter/flutter#51807 - Flutter branching for releases
Future work
Create an
updateBranchmethod inFlutterBuildStateto changecurrentBranchto update the UI.