Reserve task regardless of branches#695
Merged
keyonghan merged 1 commit intoflutter:masterfrom Mar 19, 2020
Merged
Conversation
19 tasks
godofredoc
reviewed
Mar 18, 2020
|
|
||
| Future<FullTask> findNextTask(Agent agent) async { | ||
| await for (Commit commit in datastore.queryRecentCommits()) { | ||
| await for (Commit commit in datastore.queryRecentCommitsNoBranch()) { |
Contributor
There was a problem hiding this comment.
Did you forget uploading the file with this method? or was already there?
Contributor
Author
There was a problem hiding this comment.
godofredoc
approved these changes
Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are implementing support for branching,
reserve-taskAPI reserves tasks for the defaultmasterbranch only before this PR.This PR fixes that by reserving tasks regardless of branches. It will reserve tasks for latest commits first, no matter what branch it is.
In the future, we may need to adjust priority to run tasks for different branches.