Add retries to buildbucket tries.#985
Merged
godofredoc merged 2 commits intoflutter:masterfrom Nov 3, 2020
godofredoc:retry_on_failure
Merged
Add retries to buildbucket tries.#985godofredoc merged 2 commits intoflutter:masterfrom godofredoc:retry_on_failure
godofredoc merged 2 commits intoflutter:masterfrom
godofredoc:retry_on_failure
Conversation
Sometimes the buildbucket requests are raising exceptions and github status stays on pending forever. Bug: flutter/flutter#69547
CaseyHillers
approved these changes
Nov 3, 2020
| () async { | ||
| await buildBucketClient.batch(BatchRequest(requests: requests)); | ||
| }, | ||
| retryIf: (Exception e) => e is BuildBucketException, |
Contributor
There was a problem hiding this comment.
This will only do retries with in a 2 second span. Should we modify delayFactor to be longer? Like 1s, 10s, 30s?
Contributor
Author
There was a problem hiding this comment.
Added a 2 sec delayFactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the buildbucket requests are raising exceptions and github
status stays on pending forever.
Bug: flutter/flutter#69589