Skip to content

launchDevTools should use ChromeOS native browser #582

@DanTup

Description

@DanTup

Currently the launchDevTools command will try to launch Chrome-for-Linux on ChromeOS. I believe it needs to launch the default browser in that case.

I don't know if this is the best way, but I think it needs to do something like this:

final isCrOS = Platform.isLinux && File('/dev/.cros_milestone').existsSync();
if (isCrOS) {
  Process.start('x-www-browser', ['https://www.google.co.uk/']);
} else {
  // Current way
  Process.start(_executable, [
    'https://www.google.co.uk/', /* + Chrome flags? */
  ]);
}

@jacob314 can you confirm this sounds right? Webdev is doing is own launching, and will require Chrome for Linux (because it needs to pass flags), but for non-Webdev we expect to always use the native browser?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions