Skip to content

Improvements to performance tooling from UXR#2562

Merged
kenzieschmoll merged 6 commits intoflutter:masterfrom
kenzieschmoll:timeline-performance
Dec 22, 2020
Merged

Improvements to performance tooling from UXR#2562
kenzieschmoll merged 6 commits intoflutter:masterfrom
kenzieschmoll:timeline-performance

Conversation

@kenzieschmoll
Copy link
Member

Addresses part of #2497:

  • move performance tab next to timeline tab
  • rename "event details" to CPU profiler on timeline page
  • rename performance page to "CPU profiler"
  • move bottom up profiler tab to position 0

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi @DanTup in case you are directly launching links to the timeline page from vscode.

@kenzieschmoll kenzieschmoll merged commit 00d16ac into flutter:master Dec 22, 2020
@kenzieschmoll kenzieschmoll deleted the timeline-performance branch December 22, 2020 15:16
@DanTup
Copy link
Contributor

DanTup commented Dec 22, 2020

Fyi @DanTup in case you are directly launching links to the timeline page from vscode.

I am, thanks! I'll need to handle this based on the version. The current live version is 0.9.5+1. Is it safe for me to assume that >= 0.9.6 would include this, and anything < 0.9.5+1 should use the old URLs?

@kenzieschmoll
Copy link
Member Author

yes that is correct. See also #2563, which renames timeline to performance. so >= 0.9.6

"timeline" --> "performance"
"performance" --> "cpu-profiler"

@DanTup
Copy link
Contributor

DanTup commented Jan 5, 2021

Got it! I've got a fix ready to ship in a patch, though I'm a little worried about caching causing issues - I added some notes here:

#1674 (comment)

If users see the same thing I did, they might end up getting errors because the old JS still loads and we use the new page IDs.

@DanTup
Copy link
Contributor

DanTup commented Jan 7, 2021

I've published a new Dart-Code with the new page IDs (selected based on the version). I'll send a PR that removes the service worker here shortly.

If you let me know when DevTools is released, I'll re-test using the published version. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants