Rename Timeline to Performance and populate CPU profile on frame selection#2563
Merged
kenzieschmoll merged 4 commits intoflutter:masterfrom Dec 22, 2020
Merged
Rename Timeline to Performance and populate CPU profile on frame selection#2563kenzieschmoll merged 4 commits intoflutter:masterfrom
kenzieschmoll merged 4 commits intoflutter:masterfrom
Conversation
4 tasks
kenzieschmoll
commented
Dec 22, 2020
| } | ||
| } | ||
|
|
||
| if (mainIsolate == null) return; |
Member
Author
There was a problem hiding this comment.
@jacob314 this seemed to fix the flakes we were seeing. Do you see any problem with this change?
Contributor
There was a problem hiding this comment.
seems reasonable as it would crash on the next line anyway without the return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only functional change is populating a the CPU profile section of the timeline page (now performance page) when a flutter frame is selected from above. The remaining changes are renames from "timeline" to "performance".
Fixes #2497