Support passing keypresses up to IDEs to enable shortcut keys when embedded DevTools has focus#2872
Merged
DanTup merged 1 commit intoflutter:masterfrom Apr 20, 2021
Merged
Conversation
…bedded DevTools has focus Fixes flutter#2775 (with an equiv change in VS Code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
originfor the VS Code web-view appears to include a random hash, so we have to pass*forpostMessage, so this also checks that DevTools is connected to a VM Service and also that the user agent contains Electron. @jacob314 let me know if you think this is not sufficient (we could perhaps ping the server and see if it was started in embedded mode too).@helin24 if you're embedding inside an iframe (probably not, though in VS Code it's required) in IntelliJ and also need to handle keypresses, we may need to add an additional user agent check.
Fixes #2775 (with an equiv change in VS Code).