Add flag to turn on experimental features in compile time.#4584
Merged
polina-c merged 1 commit intoflutter:masterfrom Oct 6, 2022
Merged
Add flag to turn on experimental features in compile time.#4584polina-c merged 1 commit intoflutter:masterfrom
polina-c merged 1 commit intoflutter:masterfrom
Conversation
| /// "args": [ | ||
| /// "--dart-define=enable_experiments=true" | ||
| /// ] | ||
| const bool _kEnableExperiments = bool.fromEnvironment('enable_experiments'); |
Member
There was a problem hiding this comment.
would this enable an end user to hack these experiments on? end user being someone running a flutter app and debugging with devtools
Contributor
Author
There was a problem hiding this comment.
It is compile time flag. If end user compiles devtools, then yes, otherwise - no.
Do we want them to hack?
Member
There was a problem hiding this comment.
No we don't. Would there ever be an occasion where we don't want all the experiments enabled at once?
Contributor
Author
There was a problem hiding this comment.
Or we can give user build that was compiled with this flag.
Contributor
Author
There was a problem hiding this comment.
No we don't. Would there ever be an occasion where we don't want all the experiments enabled at once?
I do not think it can happen. If it does, we will adjust the code.
kenzieschmoll
approved these changes
Oct 6, 2022
CoderDake
added a commit
to CoderDake/devtools
that referenced
this pull request
Oct 10, 2022
rename release_note_helper First step towards an official verify :D add verify command add ability to print markdown make it just for a single release plural urls and add urls try the stuff Use PointerInterceptor in dialogs to allow clicks over an iFrame (flutter#4578) UX improvement to banner warnings and errors (flutter#3537) * UX improvement to banner warnings and errors * review comments * update goldens Add Use Legacy Trace Viewer setting to the Performance page (flutter#4579) Add button to toggle visibility of the Flutter frames chart (flutter#4577) Bump actions/checkout from 3.0.2 to 3.1.0 (flutter#4574) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.2 to 3.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@2541b12...93ea575) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Simplify loading data into perfetto iFrame (flutter#4580) Add --update-perfetto option to build scripts (flutter#4581) Add details to diff. (flutter#4549) Include the full path for Perfetto assets (flutter#4585) * Include the full path for Perfetto assets * fix * review comments Improvements for release documentation (flutter#4575) Update feature_flags.dart (flutter#4584) try clone repo try new paths Add case study for memory diffing. (flutter#4589) Build and test DevTools from the latest flutter candidate branch (flutter#4582) Update version tool logic for `dev` versions (flutter#4536) Update CONTRIBUTING.md (flutter#4588) Bump to dev version 2.19.0-dev.0 (flutter#4594) Clicking on file name selects file (flutter#4409) oops cd order this has a higher likelyhood to do the trikc uses seperate :D
CoderDake
pushed a commit
to CoderDake/devtools
that referenced
this pull request
Oct 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.