Fixing flakey debug panel test#6291
Merged
CoderDake merged 2 commits intoflutter:masterfrom Aug 30, 2023
Merged
Conversation
kenzieschmoll
approved these changes
Aug 30, 2023
Member
|
can we also increase the timeout for the current failure so we don't hit this one as much? |
Member
|
Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6289
I was able to reproduce locally by reducing the pump duration, after setting a breakpoint, to 1 millisecond.
Therefore I think it would be reasonable to use the 6 second pump, rather than 3s, to give the callstack a bit more time to load.
If we are still having a consistent amount of flake, then we can rediscuss.