Replace build_e2e.dart with devtools_tool serve command#6638
Merged
kenzieschmoll merged 4 commits intoflutter:masterfrom Nov 1, 2023
Merged
Replace build_e2e.dart with devtools_tool serve command#6638kenzieschmoll merged 4 commits intoflutter:masterfrom
build_e2e.dart with devtools_tool serve command#6638kenzieschmoll merged 4 commits intoflutter:masterfrom
Conversation
elliette
reviewed
Nov 1, 2023
tool/lib/commands/serve.dart
Outdated
| final localDartSdkLocation = Platform.environment['LOCAL_DART_SDK']; | ||
| if (localDartSdkLocation == null) { | ||
| throw Exception('LOCAL_DART_SDK environment variable not set. Please add ' | ||
| 'the following to your \'.bash_profile\' or \'.bash_rc\' file:\n' |
kenzieschmoll
commented
Nov 1, 2023
Comment on lines
+83
to
+86
| throw Exception('LOCAL_DART_SDK environment variable not set. Please add ' | ||
| 'the following to your \'.bash_profile\' or \'.bashrc\' file:\n' | ||
| 'export LOCAL_DART_SDK=<absolute/path/to/my/dart/sdk>'); | ||
| } |
Member
Author
There was a problem hiding this comment.
@DanTup how can we tweak this exception to be useful for windows? We can do
final exceptionMessage = Platform.isWindows ? ... : ...;
throw Exception(exceptionMessage);
Contributor
There was a problem hiding this comment.
I would probably just say something like
Please set the LOCAL_DART_SDK environment variable in Windows to <absolute/path/to/my/dart/sdk>
Unfortunately I've never found a good page on the MS site on how to set environment variables, but there are plenty of unofficial sites with instructions for all versions of Windows.
Member
|
CONTRIBUTING.md should also be updated |
Contributor
Thanks! I'll do this soon - I'm going to need to update the VS Code bits (changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #6324