Allow --machine/--allow-embedding to be passed to devtools_tool serve#6670
Allow --machine/--allow-embedding to be passed to devtools_tool serve#6670DanTup merged 2 commits intoflutter:masterfrom
Conversation
|
(converted to draft... there are other flags we pass in VS Code like |
|
Actually, I'm ditching |
de7f4c5 to
eb66845
Compare
|
(this is ready for review now and hopefully the bots will be green 🤞) |
kenzieschmoll
left a comment
There was a problem hiding this comment.
I'm surprised that these weren't passed through automatically since we pass any unhandled arguments along to the dds command. but lgtm
I was too.. seems to be a difference between arguments and the named options. There's an |
The arg parser allows additional arguments, but not additional "options", so we need to add this explicitly* to allow
--machineto work. The code already passes the extra args through to the server correctly, it just wasn't allowing this option to be provided on the command line.* Or use the
AllowAnythingParser, but looks like that would affect the existing options.