Accept project root paths in debug sessions for sidebar#6715
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Nov 14, 2023
Merged
Accept project root paths in debug sessions for sidebar#6715auto-submit[bot] merged 2 commits intoflutter:masterfrom
auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
| /// - When the version of Dart-Code is from before this field was added | ||
| /// - When a debug session was an attach and we didn't know the source | ||
| /// - When the program being run is a lose file without any pubspec | ||
| String? get projectRootPath; |
Member
There was a problem hiding this comment.
just to be clear, this is the path that should contain the .dart_tool/ folder?
Contributor
Author
There was a problem hiding this comment.
It's the folder where we found the nearest pubspec.yaml while walking upwards. I think that's always the same thing?
I've updated the comment to mention this explicitly ("The full path to the root of this project (the folder that contains the pubspec.yaml).")
kenzieschmoll
approved these changes
Nov 13, 2023
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/devtools/6715, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 1/3 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
Failure looks like it might be a repeat of #6289 which was thought to be fixed by #6291: https://github.com/flutter/devtools/actions/runs/6861908888/job/18658577906?pr=6715 Re-running... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6709
Dart-Code will pass a project root* for debug sessions:
* if it's able to compute one - which it always should for the cases we care about, but there are some edge cases that mean the field might be missing.