Fix a skipped test in inspector_service_test (was a false positive) by bartekpacia · Pull Request #6942 · flutter/devtools

bartekpacia · 2023-12-11T20:09:52Z

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read the [Flutter Style Guide] recently, and have followed its advice.
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or there is a reason for not adding tests.

bartekpacia · 2023-12-11T21:20:44Z

@kenzieschmoll looks like the tests don't run on latest master branch?

kenzieschmoll · 2023-12-12T00:37:56Z

There can be a few days of latency. When our CI starts failing at master because the flutter version caught up, we can land this PR to fix it. Thanks!

jacob314

Thanks for fixing.
Fyi @goderbauer is the identifier property on Semantics important enough that we want to show it in the debugging output even when it is null?

bartekpacia · 2023-12-12T19:47:10Z

I'm not @goderbauer but since I added Semantics.identifier recently I'll say that it's not. I agree it can be removed when it's null.
If you agree I can make appropriate changes to the framework and to this PR.

goderbauer · 2023-12-12T20:24:52Z

Fyi @goderbauer is the identifier property on Semantics important enough that we want to show it in the debugging output even when it is null?

@chunhtai Do you have an opinion here?

chunhtai · 2023-12-12T20:37:01Z

I don't think it should show up if it is null, the tooltip probably shouldn't show up as well. I can't see how they may be useful here.

@bartekpacia can you adjust the SemanticsProperties.debugFillProperties to give them a default value so it wouldn't show up here?

) This PR applies [the suggestion made here](flutter/devtools#6942 (comment)).

bartekpacia · 2023-12-18T21:50:10Z

I implemented @chunhtai's suggestion from above in flutter/flutter#140283, I think we now have to wait a few days until a framework roll into devtools.

kenzieschmoll · 2023-12-19T19:30:11Z

Will the golden output here need to be modified for your latest Flutter PR?

bartekpacia · 2023-12-19T21:37:12Z

Yes, after changes from my latest PR both identifier and tooltip won't be shown in the inspector if they're null.

kenzieschmoll · 2023-12-20T18:47:26Z

packages/devtools_app/test/test_infra/goldens/inspector_service_details_tree.txt

+           │ identifier: null
           │ tooltip: null


Don't these need to be removed now?

That's right.

I was waiting for framework roll.

…ter#140283) This PR applies [the suggestion made here](flutter/devtools#6942 (comment)).

bartekpacia · 2024-01-03T23:19:44Z

@kenzieschmoll The tests are failing, is the approval intentional?

BTW I looked briefly at the error message and can't understand why it fails:

Logs

/home/runner/work/devtools/devtools/packages/devtools_app/test/inspector/inspector_service_test.dart: inspector service tests widget tree (failed)
  Retry: inspector service tests widget tree
  Retry: inspector service tests widget tree
  Retry: inspector service tests widget tree
  Expected: multi line description equals MaterialApp
             │ state: _MaterialAppState#00000
             │
             └─ScrollConfiguration
               │ behavior: MaterialScrollBehavior
               │
               └─HeroControllerScope
                 └─Focus
                   │ state: _FocusState#00000
                   │
                   └─_FocusInheritedScope
                     └─Semantics
                       │ container: false
                       │ properties: SemanticsProperties
                       │ renderObject: RenderSemanticsAnnotations#00000
                       │
                       └─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]
                         │ state: _WidgetsAppState#00000
                         │
                         └─RootRestorationScope
                           │ state: _RootRestorationScopeState#00000
                           │
                           └─UnmanagedRestorationScope
                             └─RestorationScope
                               │ dependencies: [UnmanagedRestorationScope]
                               │ state: _RestorationScopeState#00000
                               │
                               └─UnmanagedRestorationScope
                                 └─SharedAppData
            ...
    Actual: 'MaterialApp\n'
              ' │ state: _MaterialAppState#02a34\n'
              ' │\n'
              ' └─ScrollConfiguration\n'
              '   │ behavior: MaterialScrollBehavior\n'
              '   │\n'
              '   └─HeroControllerScope\n'
              '     └─Focus\n'
              '       │ state: _FocusState#b2e55\n'
              '       │\n'
              '       └─_FocusInheritedScope\n'
              '         └─Semantics\n'
              '           │ container: false\n'
              '           │ properties: SemanticsProperties\n'
              '           │ renderObject: RenderSemanticsAnnotations#77e66\n'
              '           │\n'
              '           └─WidgetsApp-[GlobalObjectKey _MaterialAppState#02a34]\n'
              '             │ state: _WidgetsAppState#37387\n'
              '             │\n'
              '             └─RootRestorationScope\n'
              '               │ state: _RootRestorationScopeState#e6f37\n'
              '               │\n'
              '               └─UnmanagedRestorationScope\n'
              '                 └─RestorationScope\n'
              '                   │ dependencies: [UnmanagedRestorationScope]\n'
              '                   │ state: _RestorationScopeState#97be7\n'
              '                   │\n'
              '                   └─UnmanagedRestorationScope\n'
              '                     └─SharedAppData\n'
              '                       │ state: _SharedAppDataState#358b3\n'
              '...'
     Which: expected golden file 'test/test_infra/goldens/inspector_service_details_tree.txt' with normalized value
              'MaterialApp\n'
              ' │ state: _MaterialAppState#00000\n'
              ' │\n'
              ' └─ScrollConfiguration\n'
              '   │ behavior: MaterialScrollBehavior\n'
              '   │\n'
              '   └─HeroControllerScope\n'
              '     └─Focus\n'
              '       │ state: _FocusState#00000\n'
              '       │\n'
              '       └─_FocusInheritedScope\n'
              '         └─Semantics\n'
              '           │ container: false\n'
              '           │ properties: SemanticsProperties\n'
              '           │ renderObject: RenderSemanticsAnnotations#00000\n'
              '           │\n'
              '           └─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]\n'
              '             │ state: _WidgetsAppState#00000\n'
              '             │\n'
              '             └─RootRestorationScope\n'
              '               │ state: _RootRestorationScopeState#00000\n'
              '               │\n'
              '               └─UnmanagedRestorationScope\n'
              '                 └─RestorationScope\n'
              '                   │ dependencies: [UnmanagedRestorationScope]\n'
              '                   │ state: _RestorationScopeState#00000\n'
              '                   │\n'
              '                   └─UnmanagedRestorationScope\n'
              '                     └─SharedAppData\n'
              '...'
            but got
              'MaterialApp\n'
              ' │ state: _MaterialAppState#00000\n'
              ' │\n'
              ' └─ScrollConfiguration\n'
              '   │ behavior: MaterialScrollBehavior\n'
              '   │\n'
              '   └─HeroControllerScope\n'
              '     └─Focus\n'
              '       │ state: _FocusState#00000\n'
              '       │\n'
              '       └─_FocusInheritedScope\n'
              '         └─Semantics\n'
              '           │ container: false\n'
              '           │ properties: SemanticsProperties\n'
              '           │ renderObject: RenderSemanticsAnnotations#00000\n'
              '           │\n'
              '           └─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]\n'
              '             │ state: _WidgetsAppState#00000\n'
              '             │\n'
              '             └─RootRestorationScope\n'
              '               │ state: _RootRestorationScopeState#00000\n'
              '               │\n'
              '               └─UnmanagedRestorationScope\n'
              '                 └─RestorationScope\n'
              '                   │ dependencies: [UnmanagedRestorationScope]\n'
              '                   │ state: _RestorationScopeState#00000\n'
              '                   │\n'
              '                   └─UnmanagedRestorationScope\n'
              '                     └─SharedAppData\n'
              '                       │ state: _SharedAppDataState#00000\n'
              '...'
            To update golden files run:
              tool/update_goldens.sh"
            
  
  package:matcher                                     expect
  package:flutter_test/src/widget_tester.dart 474:18  expect
  test/inspector/inspector_service_test.dart 401:9    main.<fn>.<fn>
  Expected: multi line description equals MaterialApp
             │ state: _MaterialAppState#00000
             │
             └─ScrollConfiguration
               │ behavior: MaterialScrollBehavior
               │
               └─HeroControllerScope
                 └─Focus
                   │ state: _FocusState#00000
                   │
                   └─_FocusInheritedScope
                     └─Semantics
                       │ container: false
                       │ properties: SemanticsProperties
                       │ renderObject: RenderSemanticsAnnotations#00000
                       │
                       └─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]
                         │ state: _WidgetsAppState#00000
                         │
                         └─RootRestorationScope
                           │ state: _RootRestorationScopeState#00000
                           │
                           └─UnmanagedRestorationScope
                             └─RestorationScope
                               │ dependencies: [UnmanagedRestorationScope]
                               │ state: _RestorationScopeState#00000
                               │
                               └─UnmanagedRestorationScope
                                 └─SharedAppData
            ...
    Actual: 'MaterialApp\n'
              ' │ state: _MaterialAppState#02a34\n'
              ' │\n'
              ' └─ScrollConfiguration\n'
              '   │ behavior: MaterialScrollBehavior\n'
              '   │\n'
              '   └─HeroControllerScope\n'
              '     └─Focus\n'
              '       │ state: _FocusState#b2e55\n'
              '       │\n'
              '       └─_FocusInheritedScope\n'
              '         └─Semantics\n'
              '           │ container: false\n'
              '           │ properties: SemanticsProperties\n'
              '           │ renderObject: RenderSemanticsAnnotations#77e66\n'
              '           │\n'
              '           └─WidgetsApp-[GlobalObjectKey _MaterialAppState#02a34]\n'
              '             │ state: _WidgetsAppState#37387\n'
              '             │\n'
              '             └─RootRestorationScope\n'
              '               │ state: _RootRestorationScopeState#e6f37\n'
              '               │\n'
              '               └─UnmanagedRestorationScope\n'
              '                 └─RestorationScope\n'
              '                   │ dependencies: [UnmanagedRestorationScope]\n'
              '                   │ state: _RestorationScopeState#97be7\n'
              '                   │\n'
              '                   └─UnmanagedRestorationScope\n'
              '                     └─SharedAppData\n'
              '                       │ state: _SharedAppDataState#358b3\n'
              '...'
     Which: expected golden file 'test/test_infra/goldens/inspector_service_details_tree.txt' with normalized value
              'MaterialApp\n'
              ' │ state: _MaterialAppState#00000\n'
              ' │\n'
              ' └─ScrollConfiguration\n'
              '   │ behavior: MaterialScrollBehavior\n'
              '   │\n'
              '   └─HeroControllerScope\n'
              '     └─Focus\n'
              '       │ state: _FocusState#00000\n'
              '       │\n'
              '       └─_FocusInheritedScope\n'
              '         └─Semantics\n'
              '           │ container: false\n'
              '           │ properties: SemanticsProperties\n'
              '           │ renderObject: RenderSemanticsAnnotations#00000\n'
              '           │\n'
              '           └─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]\n'
              '             │ state: _WidgetsAppState#00000\n'
              '             │\n'
              '             └─RootRestorationScope\n'
              '               │ state: _RootRestorationScopeState#00000\n'
              '               │\n'
              '               └─UnmanagedRestorationScope\n'
              '                 └─RestorationScope\n'
              '                   │ dependencies: [UnmanagedRestorationScope]\n'
              '                   │ state: _RestorationScopeState#00000\n'
              '                   │\n'
              '                   └─UnmanagedRestorationScope\n'
              '                     └─SharedAppData\n'
              '...'
            but got
              'MaterialApp\n'
              ' │ state: _MaterialAppState#00000\n'
              ' │\n'
              ' └─ScrollConfiguration\n'
              '   │ behavior: MaterialScrollBehavior\n'
              '   │\n'
              '   └─HeroControllerScope\n'
              '     └─Focus\n'
              '       │ state: _FocusState#00000\n'
              '       │\n'
              '       └─_FocusInheritedScope\n'
              '         └─Semantics\n'
              '           │ container: false\n'
              '           │ properties: SemanticsProperties\n'
              '           │ renderObject: RenderSemanticsAnnotations#00000\n'
              '           │\n'
              '           └─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]\n'
              '             │ state: _WidgetsAppState#00000\n'
              '             │\n'
              '             └─RootRestorationScope\n'
              '               │ state: _RootRestorationScopeState#00000\n'
              '               │\n'
              '               └─UnmanagedRestorationScope\n'
              '                 └─RestorationScope\n'
              '                   │ dependencies: [UnmanagedRestorationScope]\n'
              '                   │ state: _RestorationScopeState#00000\n'
              '                   │\n'
              '                   └─UnmanagedRestorationScope\n'
              '                     └─SharedAppData\n'
              '                       │ state: _SharedAppDataState#00000\n'
              '...'
            To update golden files run:
              tool/update_goldens.sh"
            
  
  package:matcher                                     expect
  package:flutter_test/src/widget_tester.dart 474:18  expect
  test/inspector/inspector_service_test.dart 401:9    main.<fn>.<fn>
  Expected: multi line description equals MaterialApp
             │ state: _MaterialAppState#00000
             │
             └─ScrollConfiguration
               │ behavior: MaterialScrollBehavior
               │
               └─HeroControllerScope
                 └─Focus
                   │ state: _FocusState#00000
                   │
                   └─_FocusInheritedScope
                     └─Semantics
                       │ container: false
                       │ properties: SemanticsProperties
                       │ renderObject: RenderSemanticsAnnotations#00000
                       │
                       └─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]
                         │ state: _WidgetsAppState#00000
                         │
                         └─RootRestorationScope
                           │ state: _RootRestorationScopeState#00000
                           │
                           └─UnmanagedRestorationScope
                             └─RestorationScope
                               │ dependencies: [UnmanagedRestorationScope]
                               │ state: _RestorationScopeState#00000
                               │
                               └─UnmanagedRestorationScope
                                 └─SharedAppData
            ...
    Actual: 'MaterialApp\n'
              ' │ state: _MaterialAppState#02a34\n'
              ' │\n'
              ' └─ScrollConfiguration\n'
              '   │ behavior: MaterialScrollBehavior\n'
              '   │\n'
              '   └─HeroControllerScope\n'
              '     └─Focus\n'
              '       │ state: _FocusState#b2e55\n'
              '       │\n'
              '       └─_FocusInheritedScope\n'
              '         └─Semantics\n'
              '           │ container: false\n'
              '           │ properties: SemanticsProperties\n'
              '           │ renderObject: RenderSemanticsAnnotations#77e66\n'
              '           │\n'
              '           └─WidgetsApp-[GlobalObjectKey _MaterialAppState#02a34]\n'
              '             │ state: _WidgetsAppState#37387\n'
              '             │\n'
              '             └─RootRestorationScope\n'
              '               │ state: _RootRestorationScopeState#e6f37\n'
              '               │\n'
              '               └─UnmanagedRestorationScope\n'
              '                 └─RestorationScope\n'
              '                   │ dependencies: [UnmanagedRestorationScope]\n'
              '                   │ state: _RestorationScopeState#97be7\n'
              '                   │\n'
              '                   └─UnmanagedRestorationScope\n'
              '                     └─SharedAppData\n'
              '                       │ state: _SharedAppDataState#358b3\n'
              '...'
     Which: expected golden file 'test/test_infra/goldens/inspector_service_details_tree.txt' with normalized value
              'MaterialApp\n'
              ' │ state: _MaterialAppState#00000\n'
              ' │\n'
              ' └─ScrollConfiguration\n'
              '   │ behavior: MaterialScrollBehavior\n'
              '   │\n'
              '   └─HeroControllerScope\n'
              '     └─Focus\n'
              '       │ state: _FocusState#00000\n'
              '       │\n'
              '       └─_FocusInheritedScope\n'
              '         └─Semantics\n'
              '           │ container: false\n'
              '           │ properties: SemanticsProperties\n'
              '           │ renderObject: RenderSemanticsAnnotations#00000\n'
              '           │\n'
              '           └─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]\n'
              '             │ state: _WidgetsAppState#00000\n'
              '             │\n'
              '             └─RootRestorationScope\n'
              '               │ state: _RootRestorationScopeState#00000\n'
              '               │\n'
              '               └─UnmanagedRestorationScope\n'
              '                 └─RestorationScope\n'
              '                   │ dependencies: [UnmanagedRestorationScope]\n'
              '                   │ state: _RestorationScopeState#00000\n'
              '                   │\n'
              '                   └─UnmanagedRestorationScope\n'
              '                     └─SharedAppData\n'
              '...'
            but got
              'MaterialApp\n'
              ' │ state: _MaterialAppState#00000\n'
              ' │\n'
              ' └─ScrollConfiguration\n'
              '   │ behavior: MaterialScrollBehavior\n'
              '   │\n'
              '   └─HeroControllerScope\n'
              '     └─Focus\n'
              '       │ state: _FocusState#00000\n'
              '       │\n'
              '       └─_FocusInheritedScope\n'
              '         └─Semantics\n'
              '           │ container: false\n'
              '           │ properties: SemanticsProperties\n'
              '           │ renderObject: RenderSemanticsAnnotations#00000\n'
              '           │\n'
              '           └─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]\n'
              '             │ state: _WidgetsAppState#00000\n'
              '             │\n'
              '             └─RootRestorationScope\n'
              '               │ state: _RootRestorationScopeState#00000\n'
              '               │\n'
              '               └─UnmanagedRestorationScope\n'
              '                 └─RestorationScope\n'
              '                   │ dependencies: [UnmanagedRestorationScope]\n'
              '                   │ state: _RestorationScopeState#00000\n'
              '                   │\n'
              '                   └─UnmanagedRestorationScope\n'
              '                     └─SharedAppData\n'
              '                       │ state: _SharedAppDataState#00000\n'
              '...'
            To update golden files run:
              tool/update_goldens.sh"
            
  
  package:matcher                                     expect
  package:flutter_test/src/widget_tester.dart 474:18  expect
  test/inspector/inspector_service_test.dart 401:9    main.<fn>.<fn>
  Expected: multi line description equals MaterialApp
             │ state: _MaterialAppState#00000
             │
             └─ScrollConfiguration
               │ behavior: MaterialScrollBehavior
               │
               └─HeroControllerScope
                 └─Focus
                   │ state: _FocusState#00000
                   │
                   └─_FocusInheritedScope
                     └─Semantics
                       │ container: false
                       │ properties: SemanticsProperties
                       │ renderObject: RenderSemanticsAnnotations#00000
                       │
                       └─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]
                         │ state: _WidgetsAppState#00000
                         │
                         └─RootRestorationScope
                           │ state: _RootRestorationScopeState#00000
                           │
                           └─UnmanagedRestorationScope
                             └─RestorationScope
                               │ dependencies: [UnmanagedRestorationScope]
                               │ state: _RestorationScopeState#00000
                               │
                               └─UnmanagedRestorationScope
                                 └─SharedAppData
            ...
    Actual: 'MaterialApp\n'
              ' │ state: _MaterialAppState#02a34\n'
              ' │\n'
              ' └─ScrollConfiguration\n'
              '   │ behavior: MaterialScrollBehavior\n'
              '   │\n'
              '   └─HeroControllerScope\n'
              '     └─Focus\n'
              '       │ state: _FocusState#b2e55\n'
              '       │\n'
              '       └─_FocusInheritedScope\n'
              '         └─Semantics\n'
              '           │ container: false\n'
              '           │ properties: SemanticsProperties\n'
              '           │ renderObject: RenderSemanticsAnnotations#77e66\n'
              '           │\n'
              '           └─WidgetsApp-[GlobalObjectKey _MaterialAppState#02a34]\n'
              '             │ state: _WidgetsAppState#37387\n'
              '             │\n'
              '             └─RootRestorationScope\n'
              '               │ state: _RootRestorationScopeState#e6f37\n'
              '               │\n'
              '               └─UnmanagedRestorationScope\n'
              '                 └─RestorationScope\n'
              '                   │ dependencies: [UnmanagedRestorationScope]\n'
              '                   │ state: _RestorationScopeState#97be7\n'
              '                   │\n'
              '                   └─UnmanagedRestorationScope\n'
              '                     └─SharedAppData\n'
              '                       │ state: _SharedAppDataState#358b3\n'
              '...'
     Which: expected golden file 'test/test_infra/goldens/inspector_service_details_tree.txt' with normalized value
              'MaterialApp\n'
              ' │ state: _MaterialAppState#00000\n'
              ' │\n'
              ' └─ScrollConfiguration\n'
              '   │ behavior: MaterialScrollBehavior\n'
              '   │\n'
              '   └─HeroControllerScope\n'
              '     └─Focus\n'
              '       │ state: _FocusState#00000\n'
              '       │\n'
              '       └─_FocusInheritedScope\n'
              '         └─Semantics\n'
              '           │ container: false\n'
              '           │ properties: SemanticsProperties\n'
              '           │ renderObject: RenderSemanticsAnnotations#00000\n'
              '           │\n'
              '           └─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]\n'
              '             │ state: _WidgetsAppState#00000\n'
              '             │\n'
              '             └─RootRestorationScope\n'
              '               │ state: _RootRestorationScopeState#00000\n'
              '               │\n'
              '               └─UnmanagedRestorationScope\n'
              '                 └─RestorationScope\n'
              '                   │ dependencies: [UnmanagedRestorationScope]\n'
              '                   │ state: _RestorationScopeState#00000\n'
              '                   │\n'
              '                   └─UnmanagedRestorationScope\n'
              '                     └─SharedAppData\n'
              '...'
            but got
              'MaterialApp\n'
              ' │ state: _MaterialAppState#00000\n'
              ' │\n'
              ' └─ScrollConfiguration\n'
              '   │ behavior: MaterialScrollBehavior\n'
              '   │\n'
              '   └─HeroControllerScope\n'
              '     └─Focus\n'
              '       │ state: _FocusState#00000\n'
              '       │\n'
              '       └─_FocusInheritedScope\n'
              '         └─Semantics\n'
              '           │ container: false\n'
              '           │ properties: SemanticsProperties\n'
              '           │ renderObject: RenderSemanticsAnnotations#00000\n'
              '           │\n'
              '           └─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]\n'
              '             │ state: _WidgetsAppState#00000\n'
              '             │\n'
              '             └─RootRestorationScope\n'
              '               │ state: _RootRestorationScopeState#00000\n'
              '               │\n'
              '               └─UnmanagedRestorationScope\n'
              '                 └─RestorationScope\n'
              '                   │ dependencies: [UnmanagedRestorationScope]\n'
              '                   │ state: _RestorationScopeState#00000\n'
              '                   │\n'
              '                   └─UnmanagedRestorationScope\n'
              '                     └─SharedAppData\n'
              '                       │ state: _SharedAppDataState#00000\n'
              '...'
            To update golden files run:
              tool/update_goldens.sh"
            
  
  package:matcher                                     expect
  package:flutter_test/src/widget_tester.dart 474:18  expect
  test/inspector/inspector_service_test.dart 401:9    main.<fn>.<fn>

goderbauer · 2024-03-12T22:41:36Z

Spoke to @kenzieschmoll about this last week and she said she's gonna take another look at this.

bartekpacia · 2024-03-12T22:56:34Z

Thanks for the update @goderbauer!

…ctor_service_test_reenable

this hash includes flutter/devtools#6942, which unskips an inspector test.

bartekpacia added the release-notes-not-required label Dec 11, 2023

bartekpacia requested review from a team and CoderDake as code owners December 11, 2023 20:09

jacob314 self-requested a review December 12, 2023 19:31

jacob314 approved these changes Dec 12, 2023

View reviewed changes

bartekpacia mentioned this pull request Dec 17, 2023

SemanticsProperties: default identifier and tooltip to null flutter/flutter#140283

Merged

8 tasks

bartekpacia changed the title ~~FIx a skipped test in inspector_service_test (was a false positive)~~ Fix a skipped test in inspector_service_test (was a false positive) Dec 17, 2023

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 18, 2023

SemanticsProperties: default identifier and tooltip to null (#140283

a438877

) This PR applies [the suggestion made here](flutter/devtools#6942 (comment)).

kenzieschmoll reviewed Dec 20, 2023

View reviewed changes

CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023

SemanticsProperties: default identifier and tooltip to null (flut…

a37e996

…ter#140283) This PR applies [the suggestion made here](flutter/devtools#6942 (comment)).

fix temporarily disabled inspector_service_test

2645e3b

kenzieschmoll approved these changes Jan 3, 2024

View reviewed changes

kenzieschmoll added 3 commits March 13, 2024 11:24

Merge branch 'master' of github.com:flutter/devtools into tests/inspe…

f4ca475

…ctor_service_test_reenable

Fix up goldens

1987a24

Merge branch 'master' of github.com:flutter/devtools into tests/inspe…

3580302

…ctor_service_test_reenable

kenzieschmoll merged commit 7ecbaae into flutter:master Mar 13, 2024

kenzieschmoll mentioned this pull request Mar 13, 2024

Update flutter_devtools.test hash flutter/tests#354

Merged

bartekpacia deleted the tests/inspector_service_test_reenable branch March 13, 2024 22:57

auto-submit bot pushed a commit to flutter/tests that referenced this pull request Mar 14, 2024

Update flutter_devtools.test hash (#354)

a7178fe

this hash includes flutter/devtools#6942, which unskips an inspector test.

Conversation

bartekpacia commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

bartekpacia commented Dec 11, 2023

Uh oh!

kenzieschmoll commented Dec 12, 2023

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Uh oh!

bartekpacia commented Dec 12, 2023

Uh oh!

goderbauer commented Dec 12, 2023

Uh oh!

chunhtai commented Dec 12, 2023

Uh oh!

bartekpacia commented Dec 18, 2023

Uh oh!

kenzieschmoll commented Dec 19, 2023

Uh oh!

bartekpacia commented Dec 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenzieschmoll Dec 20, 2023

Choose a reason for hiding this comment

Uh oh!

bartekpacia Jan 1, 2024

Choose a reason for hiding this comment

Uh oh!

bartekpacia commented Jan 3, 2024

Uh oh!

goderbauer commented Mar 12, 2024

Uh oh!

bartekpacia commented Mar 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bartekpacia commented Dec 11, 2023 •

edited

Loading

bartekpacia commented Dec 19, 2023 •

edited

Loading