Handle breaking changes in package:vm_service v14#6953
Merged
derekxu16 merged 8 commits intoflutter:masterfrom Feb 2, 2024
Merged
Handle breaking changes in package:vm_service v14#6953derekxu16 merged 8 commits intoflutter:masterfrom
derekxu16 merged 8 commits intoflutter:masterfrom
Conversation
8 tasks
derekxu16
force-pushed
the
handle-changes-in-pkg-vm-service
branch
from
bddf37f to
8f3fb23
Compare
derekxu16
force-pushed
the
handle-changes-in-pkg-vm-service
branch
from
8f3fb23 to
e231f34
Compare
derekxu16
requested review from
a team,
bkonyi and
kenzieschmoll
as code owners
packages/devtools_app/lib/src/screens/network/network_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/network/network_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/network/network_service.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Jan 16, 2024
Member
kenzieschmoll
left a comment
kenzieschmoll
left a comment
There was a problem hiding this comment.
one request to de-dupe. then lgtm
bkonyi
approved these changes
Jan 17, 2024
packages/devtools_app/lib/src/screens/network/network_service.dart
Outdated
Show resolved
Hide resolved
derekxu16
force-pushed
the
handle-changes-in-pkg-vm-service
branch
from
fac7642 to
2d158f8
Compare
derekxu16
force-pushed
the
handle-changes-in-pkg-vm-service
branch
2 times, most recently
from
8f67165 to
a488936
Compare
Contributor
|
@derekxu16 I rolled vm_service 14 to flutter/flutter in flutter/flutter#141427 |
derekxu16
force-pushed
the
handle-changes-in-pkg-vm-service
branch
2 times, most recently
from
565eebb to
3d8b718
Compare
Contributor
Author
Thanks! |
derekxu16
force-pushed
the
handle-changes-in-pkg-vm-service
branch
from
3d8b718 to
c813f7a
Compare
Contributor
Author
|
The problem described above actually didn't apply, I just needed to change a call in |
derekxu16
force-pushed
the
handle-changes-in-pkg-vm-service
branch
from
20ca33c to
6d96471
Compare
…ocketProfilingEnabled
derekxu16
force-pushed
the
handle-changes-in-pkg-vm-service
branch
from
6d96471 to
59b31d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package:vm_servicev14 includes breaking changes to the dart:io service extensions. This PR updates thepackage:vm_serviceconstraint to^14.0.0and updates DevTools in response to those changes.