Unskip the wasm benchmark#8320
Merged
kenzieschmoll merged 19 commits intoflutter:masterfrom Oct 9, 2024
Merged
Conversation
Member
Author
|
EDIT: this was due to an outdated Chrome version. Updating chrome fixed the issue. @eyebrowsoffire any ideas? This stack trace is with a path dependency on web_benchmarks with the flutter/packages#7743 changes applied. |
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 30, 2024
This will unblock flutter/devtools#8320. This is a follow up to the initial attempt here: #7632
Member
Author
|
This benchmark tests is failing because the Chrome version on the ubuntu-latest image is behind the current Chrome stable. The benchmarks pass locally: actions/runner-images#10726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on flutter/packages#7743 landing and
web_benchmarks3.0.0 being published.Part of general wasm effort: #7856