Accept themeChanged events via postMessage as well as DTD#8387
Merged
DanTup merged 1 commit intoflutter:masterfrom Oct 2, 2024
Merged
Accept themeChanged events via postMessage as well as DTD#8387DanTup merged 1 commit intoflutter:masterfrom
DanTup merged 1 commit intoflutter:masterfrom
Conversation
DanTup
force-pushed
the
post-message-theme-change
branch
from
fac9c92 to
d0c0018
Compare
This extracts the code that updates the theme (to `_updateTheme`) and then calls it in response to either a DTD event or a postMessage event. Fixes Dart-Code/Dart-Code#4971
DanTup
force-pushed
the
post-message-theme-change
branch
from
d0c0018 to
ba88f33
Compare
DanTup
requested review from
elliette and
kenzieschmoll
and removed request for
a team
Contributor
Author
|
@kenzieschmoll this may be easier to review with whitespace changes ignored as I extracted some code to a method which added a bit of noise in the default diff. |
kenzieschmoll
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts the code that updates the theme (to
_updateTheme) and then calls it in response to either a DTD event or a postMessage event. This allows VS Code to update the theme based on where it's embedded (in this video you can see both the sidebar and the embedded DevTools update, but they have slightly different background colors so that they match the rest of the sidebar + editor).devtools_color_theme_update.mp4
The corresponding Dart-Code work is at Dart-Code/Dart-Code#5297.
Fixes Dart-Code/Dart-Code#4971
Pre-launch Checklist
///).If you need help, consider asking for help on Discord.