This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix touchpad scrolling on Chromebook #11420
Merged
dkwingsmt merged 1 commit intoflutter:masterfrom Aug 26, 2019
Merged
Conversation
stuartmorgan-g
approved these changes
Aug 24, 2019
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM. Please add a reference to the fixed bug in the description though.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 26, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 26, 2019
[email protected]:flutter/engine.git/compare/11e3ade157db...ba1a303 git log 11e3ade..ba1a303 --no-merges --oneline 2019-08-26 [email protected] Patch buttons for chromebook touchpad (flutter/engine#11420) 2019-08-26 [email protected] Skip empty platform view overlays. (flutter/engine#11427) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Contributor
The bug system tracks the state of master, not stable, so that is expected. |
|
Whoops, sorry, that comment was intended for an internal ticket! Thanks for the fix on this! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a Chromebook, if the user scrolls using two fingers on the trackpad, ARC translates it into a mouse down-move-up event sequence with
buttons: 0, which is no longer acceptable byDragGestureRecognizer.This temporary fix patches these events by setting buttons to 1, the primary button. This is by no means perfect, besides being ugly, because it can trigger unintended drags that are not scrolling. However it is at least as good as what it used to be (before
DragGestureRecognizerstop accepting 0-button events).The correct way is to implement trackpad gestures (as in this issue), but it is a much bigger job. See flutter/flutter#23604
Related issues
Fixes flutter/flutter#36118
Tests
This change fix does not include tests, because it's very hard to emulate these irregular events and test the behavior of widgets.
To manually test it, run the example in flutter/flutter#36118 on a Chromebook and see if the list can be scrolled using trackpad.