This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add a method to flutter_window_controller to destroy the current window.#12076
Merged
stuartmorgan-g merged 3 commits intoflutter:masterfrom Sep 30, 2019
Merged
Add a method to flutter_window_controller to destroy the current window.#12076stuartmorgan-g merged 3 commits intoflutter:masterfrom
stuartmorgan-g merged 3 commits intoflutter:masterfrom
Conversation
stuartmorgan-g
suggested changes
Sep 16, 2019
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
One small change, otherwise looks good.
Member
|
@skycomposter shout when you've had a chance to update with @stuartmorgan 's feedback, then we'll merge this change. Thanks! |
Contributor
Author
|
Sorry for the delay! I addressed the comment. Thanks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 30, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 30, 2019
[email protected]:flutter/engine.git/compare/1f454c75330c...9675ca2 git log 1f454c7..9675ca2 --no-merges --oneline 2019-09-30 [email protected] Reland "Smooth out iOS irregular input events delivery (#12280)" (flutter/engine#12385) 2019-09-30 [email protected] Add missing flag for embedder. (flutter/engine#12700) 2019-09-30 [email protected] Add a method to flutter_window_controller to destroy the current window. (flutter/engine#12076) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/1f454c75330c...9675ca2 git log 1f454c7..9675ca2 --no-merges --oneline 2019-09-30 [email protected] Reland "Smooth out iOS irregular input events delivery (flutter#12280)" (flutter/engine#12385) 2019-09-30 [email protected] Add missing flag for embedder. (flutter/engine#12700) 2019-09-30 [email protected] Add a method to flutter_window_controller to destroy the current window. (flutter/engine#12076) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the embedder to be shutdown by means other than manually closing the window (e.g. by handling a SIGINT).