This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
This will have to be landed on red since it's intended to make the tree red. @mklim
Contributor
|
This LGTM. I had written a unit test with a detailed explanation mklim/engine@6d2ebfc1cbd3bf2634bde53d58211fe70e37ade2 but it probably makes more sense to make this as part of the cirrus config. Thanks Dan. |
mklim
pushed a commit
that referenced
this pull request
Sep 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 13, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 14, 2019
[email protected]:flutter/engine.git/compare/7d8c6d9c1a5c...e12decf git log 7d8c6d9..e12decf --no-merges --oneline 2019-09-13 [email protected] Clean up after AppLifecycleTests (flutter/engine#12273) 2019-09-13 [email protected] Close the tree (flutter/engine#12268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
[email protected]:flutter/engine.git/compare/7d8c6d9c1a5c...e12decf git log 7d8c6d9..e12decf --no-merges --oneline 2019-09-13 [email protected] Clean up after AppLifecycleTests (flutter/engine#12273) 2019-09-13 [email protected] Close the tree (flutter/engine#12268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will have to be landed on red since it's intended to make the tree red.
This should be reverted once we've resolved the regressions currently blocking the engine->framework roll
@mklim