Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Adding Link SemanticsFlag#12453

Merged
Piinks merged 13 commits intoflutter:masterfrom
Piinks:linkA11y
Oct 4, 2019
Merged

Adding Link SemanticsFlag#12453
Piinks merged 13 commits intoflutter:masterfrom
Piinks:linkA11y

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Sep 25, 2019

Framework counter PR: flutter/flutter#41327 - will require a manual engine roll.

Part of flutter/flutter#36306

@Piinks Piinks removed the Work in progress (WIP) Not ready (yet) for review! label Sep 30, 2019
@Piinks Piinks changed the title [WIP] Adding Link SemanticsFlag Adding Link SemanticsFlag Sep 30, 2019
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@Piinks
Copy link
Contributor Author

Piinks commented Oct 4, 2019

Landing this on red to do a manual engine roll for framework PR flutter/flutter#41327

@Piinks Piinks merged commit 974ca21 into flutter:master Oct 4, 2019
@Piinks
Copy link
Contributor Author

Piinks commented Oct 4, 2019

I'm going to revert this since I cannot complete a manual engine roll with the current status of the framework build. I will try again next week.

Piinks added a commit that referenced this pull request Oct 4, 2019
Piinks added a commit that referenced this pull request Oct 5, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 7, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 7, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 7, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 7, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 8, 2019
[email protected]:flutter/engine.git/compare/1d62160fdb2f...4a849e0

git log 1d62160..4a849e0 --no-merges --oneline
2019-10-08 [email protected] Color matrix doc (flutter/engine#12982)
2019-10-07 [email protected] Use the standard gen_snapshot target unless the platform requires host_targeting_host (flutter/engine#12988)
2019-10-07 [email protected] Roll src/third_party/dart 8413a0db0d..8ba6f7e2eb (39 commits) (flutter/engine#12981)
2019-10-07 [email protected] Unblock Fuchsia roll (flutter/engine#12977)
2019-10-06 [email protected] Update buildroot to pull in ubsan updates. (flutter/engine#12821)
2019-10-05 [email protected] Roll src/third_party/skia 95edac1c9a4a..4c82a9fc83a5 (13 commits) (flutter/engine#12818)
2019-10-05 [email protected] Enable sanitizer build variants. (flutter/engine#12816)
2019-10-05 [email protected] Revert "Adding Link SemanticsFlag (#12453)" (flutter/engine#12815)
2019-10-04 [email protected] Use the x64 host toolchain for x86 target gen_snapshot only on Linux (flutter/engine#12809)
2019-10-04 [email protected] add option for bulk-updating screenshots; update screenshots (flutter/engine#12797)
2019-10-04 [email protected] unbreak unopt fuchsia (flutter/engine#12805)
2019-10-04 [email protected] Build gen_snapshot with a 64-bit host toolchain even if the target platform is 32-bit (flutter/engine#12802)
2019-10-04 [email protected] [flutter_runner] a11y updates, tests! (flutter/engine#12380)
2019-10-04 [email protected] Fix crash in copypixelbuffer (flutter/engine#10326)
2019-10-04 [email protected] Roll src/third_party/dart d6c6d12ebf..8413a0db0d (2 commits)
2019-10-04 [email protected] Roll fuchsia/sdk/core/mac-amd64 from JyZWz... to kwa2O... (flutter/engine#12803)
2019-10-04 [email protected] Adding Link SemanticsFlag (flutter/engine#12453)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@Piinks Piinks mentioned this pull request Oct 8, 2019
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
[email protected]:flutter/engine.git/compare/1d62160fdb2f...4a849e0

git log 1d62160..4a849e0 --no-merges --oneline
2019-10-08 [email protected] Color matrix doc (flutter/engine#12982)
2019-10-07 [email protected] Use the standard gen_snapshot target unless the platform requires host_targeting_host (flutter/engine#12988)
2019-10-07 [email protected] Roll src/third_party/dart 8413a0db0d..8ba6f7e2eb (39 commits) (flutter/engine#12981)
2019-10-07 [email protected] Unblock Fuchsia roll (flutter/engine#12977)
2019-10-06 [email protected] Update buildroot to pull in ubsan updates. (flutter/engine#12821)
2019-10-05 [email protected] Roll src/third_party/skia 95edac1c9a4a..4c82a9fc83a5 (13 commits) (flutter/engine#12818)
2019-10-05 [email protected] Enable sanitizer build variants. (flutter/engine#12816)
2019-10-05 [email protected] Revert "Adding Link SemanticsFlag (flutter#12453)" (flutter/engine#12815)
2019-10-04 [email protected] Use the x64 host toolchain for x86 target gen_snapshot only on Linux (flutter/engine#12809)
2019-10-04 [email protected] add option for bulk-updating screenshots; update screenshots (flutter/engine#12797)
2019-10-04 [email protected] unbreak unopt fuchsia (flutter/engine#12805)
2019-10-04 [email protected] Build gen_snapshot with a 64-bit host toolchain even if the target platform is 32-bit (flutter/engine#12802)
2019-10-04 [email protected] [flutter_runner] a11y updates, tests! (flutter/engine#12380)
2019-10-04 [email protected] Fix crash in copypixelbuffer (flutter/engine#10326)
2019-10-04 [email protected] Roll src/third_party/dart d6c6d12ebf..8413a0db0d (2 commits)
2019-10-04 [email protected] Roll fuchsia/sdk/core/mac-amd64 from JyZWz... to kwa2O... (flutter/engine#12803)
2019-10-04 [email protected] Adding Link SemanticsFlag (flutter/engine#12453)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants