This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Build gen_snapshot with a 64-bit host toolchain even if the target platform is 32-bit#12802
Merged
jason-simmons merged 1 commit intoflutter:masterfrom Oct 4, 2019
Merged
Conversation
…atform is 32-bit By default Dart will build a gen_snapshot for the host platform using a toolchain matching the bit width of the target platform. Some host platforms no longer support 32-bit binaries, so gen_snapshot will now be built as a 64-bit host binary even if the target is 32-bit.
chinmaygarde
approved these changes
Oct 4, 2019
Contributor
|
This change broke the triple-head Flutter builder at https://ci.chromium.org/p/dart/g/flutter-hhh/console?limit=100 We are trying to fix it with https://chromium-review.googlesource.com/c/chromium/tools/build/+/1843973 If you have any input on what the right fix for this change is, please let us know. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
…arget platform is 32-bit (flutter/engine#12802)
This was referenced Oct 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
…arget platform is 32-bit (flutter/engine#12802)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 8, 2019
[email protected]:flutter/engine.git/compare/1d62160fdb2f...4a849e0 git log 1d62160..4a849e0 --no-merges --oneline 2019-10-08 [email protected] Color matrix doc (flutter/engine#12982) 2019-10-07 [email protected] Use the standard gen_snapshot target unless the platform requires host_targeting_host (flutter/engine#12988) 2019-10-07 [email protected] Roll src/third_party/dart 8413a0db0d..8ba6f7e2eb (39 commits) (flutter/engine#12981) 2019-10-07 [email protected] Unblock Fuchsia roll (flutter/engine#12977) 2019-10-06 [email protected] Update buildroot to pull in ubsan updates. (flutter/engine#12821) 2019-10-05 [email protected] Roll src/third_party/skia 95edac1c9a4a..4c82a9fc83a5 (13 commits) (flutter/engine#12818) 2019-10-05 [email protected] Enable sanitizer build variants. (flutter/engine#12816) 2019-10-05 [email protected] Revert "Adding Link SemanticsFlag (#12453)" (flutter/engine#12815) 2019-10-04 [email protected] Use the x64 host toolchain for x86 target gen_snapshot only on Linux (flutter/engine#12809) 2019-10-04 [email protected] add option for bulk-updating screenshots; update screenshots (flutter/engine#12797) 2019-10-04 [email protected] unbreak unopt fuchsia (flutter/engine#12805) 2019-10-04 [email protected] Build gen_snapshot with a 64-bit host toolchain even if the target platform is 32-bit (flutter/engine#12802) 2019-10-04 [email protected] [flutter_runner] a11y updates, tests! (flutter/engine#12380) 2019-10-04 [email protected] Fix crash in copypixelbuffer (flutter/engine#10326) 2019-10-04 [email protected] Roll src/third_party/dart d6c6d12ebf..8413a0db0d (2 commits) 2019-10-04 [email protected] Roll fuchsia/sdk/core/mac-amd64 from JyZWz... to kwa2O... (flutter/engine#12803) 2019-10-04 [email protected] Adding Link SemanticsFlag (flutter/engine#12453) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/1d62160fdb2f...4a849e0 git log 1d62160..4a849e0 --no-merges --oneline 2019-10-08 [email protected] Color matrix doc (flutter/engine#12982) 2019-10-07 [email protected] Use the standard gen_snapshot target unless the platform requires host_targeting_host (flutter/engine#12988) 2019-10-07 [email protected] Roll src/third_party/dart 8413a0db0d..8ba6f7e2eb (39 commits) (flutter/engine#12981) 2019-10-07 [email protected] Unblock Fuchsia roll (flutter/engine#12977) 2019-10-06 [email protected] Update buildroot to pull in ubsan updates. (flutter/engine#12821) 2019-10-05 [email protected] Roll src/third_party/skia 95edac1c9a4a..4c82a9fc83a5 (13 commits) (flutter/engine#12818) 2019-10-05 [email protected] Enable sanitizer build variants. (flutter/engine#12816) 2019-10-05 [email protected] Revert "Adding Link SemanticsFlag (flutter#12453)" (flutter/engine#12815) 2019-10-04 [email protected] Use the x64 host toolchain for x86 target gen_snapshot only on Linux (flutter/engine#12809) 2019-10-04 [email protected] add option for bulk-updating screenshots; update screenshots (flutter/engine#12797) 2019-10-04 [email protected] unbreak unopt fuchsia (flutter/engine#12805) 2019-10-04 [email protected] Build gen_snapshot with a 64-bit host toolchain even if the target platform is 32-bit (flutter/engine#12802) 2019-10-04 [email protected] [flutter_runner] a11y updates, tests! (flutter/engine#12380) 2019-10-04 [email protected] Fix crash in copypixelbuffer (flutter/engine#10326) 2019-10-04 [email protected] Roll src/third_party/dart d6c6d12ebf..8413a0db0d (2 commits) 2019-10-04 [email protected] Roll fuchsia/sdk/core/mac-amd64 from JyZWz... to kwa2O... (flutter/engine#12803) 2019-10-04 [email protected] Adding Link SemanticsFlag (flutter/engine#12453) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default Dart will build a gen_snapshot for the host platform using a
toolchain matching the bit width of the target platform. Some host platforms
no longer support 32-bit binaries, so gen_snapshot will now be built as a
64-bit host binary even if the target is 32-bit.