This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add templates to generate fuchsia host bundles#13158
Merged
iskakaushik merged 1 commit intoflutter:masterfrom Oct 21, 2019
Merged
Add templates to generate fuchsia host bundles#13158iskakaushik merged 1 commit intoflutter:masterfrom
iskakaushik merged 1 commit intoflutter:masterfrom
Conversation
chinmaygarde
approved these changes
Oct 17, 2019
|
|
||
| template("fuchsia_host_bundle") { | ||
| assert(defined(invoker.name), "'name' must be defined for $target_name.") | ||
| dest_dir = "${root_out_dir}/${invoker.name}-${host_os}-${host_cpu}" |
Contributor
There was a problem hiding this comment.
Maybe put this in a host_bundle subdirectory.
shell/platform/fuchsia/BUILD.gn
Outdated
| } | ||
|
|
||
| fuchsia_host_bundle("flutter_binaries") { | ||
| name = "flutter-binaries" |
Contributor
There was a problem hiding this comment.
Nit: Can we stay consistent with the use of - and _
Contributor
Author
There was a problem hiding this comment.
I was thinking of unifying all fuchsia related artifacts to using - since that seems to be the convention. That said, we could still have flutter_binaries-linux-x64. Btw, flutter-binaries-linux-x64 seems better than flutter_binaries-linux-x64, as we don't mix underscores and hyphens, no?
This is part of an effort to separate generation of host artifacts and target artifacts for fuchsia. The `fuchsia_host_bundle` template aims to capture all the artifacts that are specific to a given host. The next step would be to bundle these are separate CIPD packages for mac and linux (only x64 hosts) internal planning doc: go/flutter-fuchsia-packaging
iskakaushik
force-pushed
the
fuchsia-host-bundle
branch
from
addf8be to
235e448
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 22, 2019
[email protected]:flutter/engine.git/compare/8882bf3c73f5...39e6901 git log 8882bf3..39e6901 --no-merges --oneline 2019-10-21 [email protected] Add recipe changelog (flutter/engine#13270) 2019-10-21 [email protected] fix NPE in accessibility bridge (flutter/engine#13255) 2019-10-21 [email protected] Roll src/third_party/skia 9889d509ed9f..56f569d9bec2 (21 commits) (flutter/engine#13266) 2019-10-21 [email protected] Roll fuchsia/sdk/core/mac-amd64 from hc4p_... to hALu4... (flutter/engine#13252) 2019-10-21 [email protected] [web] Support input action (flutter/engine#13268) 2019-10-21 [email protected] [web] Support -j to use goma in felt build (flutter/engine#13259) 2019-10-21 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 30Ua7... to _e7Up... (flutter/engine#13254) 2019-10-21 [email protected] Hold a reference to the Skia unref queue in UIDartState (flutter/engine#13239) 2019-10-21 [email protected] Do not attempt to drain the SkiaUnrefQueue in the destructor (flutter/engine#13237) 2019-10-21 [email protected] Updated license script to ignore testdata directories, which often contain object files and other compilation results (flutter/engine#13261) 2019-10-21 [email protected] Add templates to generate fuchsia host bundles (flutter/engine#13158) 2019-10-21 [email protected] Update ui.instantiateImageCodec docs to reflect what it does. (flutter/engine#13233) 2019-10-21 [email protected] Update CanvasKit to 0.7.0 and flesh out painting (flutter/engine#13240) 2019-10-19 [email protected] Roll fuchsia/sdk/core/linux-amd64 from CYDvx... to 30Ua7... (flutter/engine#13251) 2019-10-19 [email protected] Roll fuchsia/sdk/core/mac-amd64 from 0JpMS... to hc4p_... (flutter/engine#13250) 2019-10-19 [email protected] Roll fuchsia/sdk/core/linux-amd64 from bdTv5... to CYDvx... (flutter/engine#13249) 2019-10-19 [email protected] Roll src/third_party/skia c65eb34d2f37..9889d509ed9f (1 commits) (flutter/engine#13248) 2019-10-19 [email protected] Roll fuchsia/sdk/core/mac-amd64 from SevlL... to 0JpMS... (flutter/engine#13244) 2019-10-19 [email protected] Roll src/third_party/skia 7605c89c00f7..c65eb34d2f37 (3 commits) (flutter/engine#13243) 2019-10-19 [email protected] Ignore *.obj files when gathering licenses (flutter/engine#13241) 2019-10-18 [email protected] Roll buildroot to 994c6 (flutter/engine#13236) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/8882bf3c73f5...39e6901 git log 8882bf3..39e6901 --no-merges --oneline 2019-10-21 [email protected] Add recipe changelog (flutter/engine#13270) 2019-10-21 [email protected] fix NPE in accessibility bridge (flutter/engine#13255) 2019-10-21 [email protected] Roll src/third_party/skia 9889d509ed9f..56f569d9bec2 (21 commits) (flutter/engine#13266) 2019-10-21 [email protected] Roll fuchsia/sdk/core/mac-amd64 from hc4p_... to hALu4... (flutter/engine#13252) 2019-10-21 [email protected] [web] Support input action (flutter/engine#13268) 2019-10-21 [email protected] [web] Support -j to use goma in felt build (flutter/engine#13259) 2019-10-21 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 30Ua7... to _e7Up... (flutter/engine#13254) 2019-10-21 [email protected] Hold a reference to the Skia unref queue in UIDartState (flutter/engine#13239) 2019-10-21 [email protected] Do not attempt to drain the SkiaUnrefQueue in the destructor (flutter/engine#13237) 2019-10-21 [email protected] Updated license script to ignore testdata directories, which often contain object files and other compilation results (flutter/engine#13261) 2019-10-21 [email protected] Add templates to generate fuchsia host bundles (flutter/engine#13158) 2019-10-21 [email protected] Update ui.instantiateImageCodec docs to reflect what it does. (flutter/engine#13233) 2019-10-21 [email protected] Update CanvasKit to 0.7.0 and flesh out painting (flutter/engine#13240) 2019-10-19 [email protected] Roll fuchsia/sdk/core/linux-amd64 from CYDvx... to 30Ua7... (flutter/engine#13251) 2019-10-19 [email protected] Roll fuchsia/sdk/core/mac-amd64 from 0JpMS... to hc4p_... (flutter/engine#13250) 2019-10-19 [email protected] Roll fuchsia/sdk/core/linux-amd64 from bdTv5... to CYDvx... (flutter/engine#13249) 2019-10-19 [email protected] Roll src/third_party/skia c65eb34d2f37..9889d509ed9f (1 commits) (flutter/engine#13248) 2019-10-19 [email protected] Roll fuchsia/sdk/core/mac-amd64 from SevlL... to 0JpMS... (flutter/engine#13244) 2019-10-19 [email protected] Roll src/third_party/skia 7605c89c00f7..c65eb34d2f37 (3 commits) (flutter/engine#13243) 2019-10-19 [email protected] Ignore *.obj files when gathering licenses (flutter/engine#13241) 2019-10-18 [email protected] Roll buildroot to 994c6 (flutter/engine#13236) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of an effort to separate generation of
host artifacts and target artifacts for fuchsia. The
fuchsia_host_bundletemplate aims to capture all theartifacts that are specific to a given host.
The next step would be to bundle these are separate CIPD
packages for mac and linux (only x64 hosts)
internal planning doc: go/flutter-fuchsia-packaging