This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[DRAFT] Calling onConnectionClosed when the input element is blurred.#13344
Closed
nturgut wants to merge 2 commits intoflutter:masterfrom
Closed
[DRAFT] Calling onConnectionClosed when the input element is blurred.#13344nturgut wants to merge 2 commits intoflutter:masterfrom
nturgut wants to merge 2 commits intoflutter:masterfrom
Conversation
mdebbar
reviewed
Oct 25, 2019
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
Looks great! Thanks for making this happen.
(I know this is still in draft mode, so I'll wait for test changes before approving)
| @@ -293,14 +293,10 @@ class TextEditingElement { | |||
| // outside the editable box. Instead it provides an explicit "done" button, | |||
| // which is reported as "blur", so we must not reacquire focus when we see | |||
| // a "blur" event and let the keyboard disappear. | |||
Contributor
There was a problem hiding this comment.
The comment isn't relevant anymore.
| browserEngine == BrowserEngine.unknown) { | ||
| _subscriptions.add(domElement.onBlur.listen((_) { | ||
| if (isEnabled) { | ||
| _refocus(); |
Contributor
There was a problem hiding this comment.
I think there are some tests for the refocus behavior. They probably need to be updated or deleted.
Contributor
Author
There was a problem hiding this comment.
Yes, I'll work on the tests later. I want to make sure the other part will me approved. Thanks for the pointers!
Contributor
Author
|
I sent a new version of this PR: #14484 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showing the usage of framework PR: flutter/flutter#43466
Tests needs to be added.
Fixes flutter/flutter#43034
combined with flutter/flutter#43466