Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Deprecated DartExecutor as BinaryMessenger and added a getBinaryMessenger() method. (#43202)#13349

Merged
matthew-carroll merged 1 commit intoflutter:masterfrom
matthew-carroll:43202_add-getBinaryMessenger-to-DartExecutor
Oct 26, 2019
Merged

Deprecated DartExecutor as BinaryMessenger and added a getBinaryMessenger() method. (#43202)#13349
matthew-carroll merged 1 commit intoflutter:masterfrom
matthew-carroll:43202_add-getBinaryMessenger-to-DartExecutor

Conversation

@matthew-carroll
Copy link
Contributor

Deprecated DartExecutor as BinaryMessenger and added a getBinaryMessenger() method. (#43202)

The stated goal of this change is to make it easier for developers to figure out where they can get a BinaryMessenger.

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit 3ebf006 into flutter:master Oct 26, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 26, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 26, 2019
…aryMessenger() method. (#43202) (flutter/engine#13349) (#43562)

[email protected]:flutter/engine.git/compare/1c104d435994...3ebf006

git log 1c104d4..3ebf006 --no-merges --oneline
2019-10-26 [email protected] Deprecated DartExecutor as BinaryMessenger and added a getBinaryMessenger() method. (#43202) (flutter/engine#13349)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
…aryMessenger() method. (flutter#43202) (flutter/engine#13349) (flutter#43562)

[email protected]:flutter/engine.git/compare/1c104d435994...3ebf006

git log 1c104d4..3ebf006 --no-merges --oneline
2019-10-26 [email protected] Deprecated DartExecutor as BinaryMessenger and added a getBinaryMessenger() method. (flutter#43202) (flutter/engine#13349)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants