Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Web: fix Color subclass handling#13359

Merged
yjbanov merged 1 commit intoflutter:masterfrom
yjbanov:fix-color-subclass-handling
Oct 25, 2019
Merged

Web: fix Color subclass handling#13359
yjbanov merged 1 commit intoflutter:masterfrom
yjbanov:fix-color-subclass-handling

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Oct 25, 2019

This is required for Cupertino widgets that pass CupertinoDynamicColor to Paint.

@yjbanov yjbanov requested a review from ferhatb October 25, 2019 20:02
@yjbanov yjbanov merged commit 797e094 into flutter:master Oct 25, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 26, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 26, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 26, 2019
[email protected]:flutter/engine.git/compare/89731aefca5b...f082b32

git log 89731ae..f082b32 --no-merges --oneline
2019-10-25 [email protected] [flutter_runner] Remove the checks for libdart profiler symbols (flutter/engine#13364)
2019-10-25 [email protected] Roll src/third_party/dart 5ba6fb73ec..5e44c0b016 (11 commits)
2019-10-25 [email protected] Roll src/third_party/skia d0a404e84d47..ff82e15d014a (5 commits) (flutter/engine#13362)
2019-10-25 [email protected] Expand on CanvasKit backend more (flutter/engine#13361)
2019-10-25 [email protected] Web: fix Color subclass handling (flutter/engine#13359)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
[email protected]:flutter/engine.git/compare/89731aefca5b...f082b32

git log 89731ae..f082b32 --no-merges --oneline
2019-10-25 [email protected] [flutter_runner] Remove the checks for libdart profiler symbols (flutter/engine#13364)
2019-10-25 [email protected] Roll src/third_party/dart 5ba6fb73ec..5e44c0b016 (11 commits)
2019-10-25 [email protected] Roll src/third_party/skia d0a404e84d47..ff82e15d014a (5 commits) (flutter/engine#13362)
2019-10-25 [email protected] Expand on CanvasKit backend more (flutter/engine#13361)
2019-10-25 [email protected] Web: fix Color subclass handling (flutter/engine#13359)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@yjbanov yjbanov deleted the fix-color-subclass-handling branch June 22, 2021 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants