This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[flutter_runner] Remove the checks for libdart profiler symbols#13364
Merged
iskakaushik merged 1 commit intoflutter:masterfrom Oct 25, 2019
Merged
Conversation
Since the runner binaries are statically linked, we do not need to look for the libdart profiler symbols separately.
chinmaygarde
approved these changes
Oct 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 26, 2019
[email protected]:flutter/engine.git/compare/89731aefca5b...f082b32 git log 89731ae..f082b32 --no-merges --oneline 2019-10-25 [email protected] [flutter_runner] Remove the checks for libdart profiler symbols (flutter/engine#13364) 2019-10-25 [email protected] Roll src/third_party/dart 5ba6fb73ec..5e44c0b016 (11 commits) 2019-10-25 [email protected] Roll src/third_party/skia d0a404e84d47..ff82e15d014a (5 commits) (flutter/engine#13362) 2019-10-25 [email protected] Expand on CanvasKit backend more (flutter/engine#13361) 2019-10-25 [email protected] Web: fix Color subclass handling (flutter/engine#13359) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/89731aefca5b...f082b32 git log 89731ae..f082b32 --no-merges --oneline 2019-10-25 [email protected] [flutter_runner] Remove the checks for libdart profiler symbols (flutter/engine#13364) 2019-10-25 [email protected] Roll src/third_party/dart 5ba6fb73ec..5e44c0b016 (11 commits) 2019-10-25 [email protected] Roll src/third_party/skia d0a404e84d47..ff82e15d014a (5 commits) (flutter/engine#13362) 2019-10-25 [email protected] Expand on CanvasKit backend more (flutter/engine#13361) 2019-10-25 [email protected] Web: fix Color subclass handling (flutter/engine#13359) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the runner binaries are statically linked, we do not need
to look for the libdart profiler symbols separately.