[fuchsia] [packaging] Create a script to upload debug symbols to CIPD by iskakaushik · Pull Request #13422 · flutter/engine

iskakaushik · 2019-10-29T21:24:27Z

No description provided.

gw280 · 2019-10-29T23:38:21Z

tools/fuchsia/merge_and_upload_debug_symbols.py

+  return temp_file
+
+
+def ProcessCIPDPakcage(upload, cipd_yaml, engine_version, out_dir, target_arch):


nit: typo ("Package")

gw280 · 2019-10-29T23:40:18Z

tools/fuchsia/merge_and_upload_debug_symbols.py

+
+def NormalizeDirPathForRsync(path):
+  norm_path = os.path.normpath(path)
+  return norm_path + os.path.sep


os.path.join is preferred

gw280 · 2019-10-29T23:42:41Z

tools/fuchsia/merge_and_upload_debug_symbols.py

+
+  out_dir = NormalizeDirPathForRsync(args.out_dir)
+  if os.path.exists(out_dir):
+    shutil.rmtree(out_dir)


This makes me a little uneasy as the caller may not expect that this script will blow away their specified output directory.

Maybe put out a warning and request user input to continue or abort

This would require a recipe change. I will file an issue for this, and maybe make the flag more descriptive like --clean-out-dir or something along those lines.

Can we at least print a warning?

gw280

LGTM

… to CIPD (flutter/engine#13422)

[email protected]:flutter/engine.git/compare/36303c61b63f...5051bef git log 36303c6..5051bef --no-merges --oneline 2019-10-30 [email protected] Roll src/third_party/skia ebdae1144978..7da048b5e8f1 (1 commits) (flutter/engine#13438) 2019-10-30 [email protected] Roll fuchsia/sdk/core/mac-amd64 from DfLN8... to p7XYM... (flutter/engine#13437) 2019-10-30 [email protected] Roll src/third_party/dart eb4ab61349..d3a5b82355 (4 commits) 2019-10-30 [email protected] Roll fuchsia/sdk/core/linux-amd64 from goLxs... to nhX22... (flutter/engine#13435) 2019-10-30 [email protected] Roll src/third_party/skia c3a51a5e47ba..ebdae1144978 (1 commits) (flutter/engine#13434) 2019-10-30 [email protected] Roll src/third_party/skia 1ae54bc22fc2..c3a51a5e47ba (1 commits) (flutter/engine#13433) 2019-10-30 [email protected] Roll src/third_party/dart ae5a86d790..eb4ab61349 (7 commits) 2019-10-30 [email protected] Set the install name at link time for darwin dylibs (flutter/engine#13428) 2019-10-30 [email protected] Add isRunningInRobolectricTest back (flutter/engine#13424) 2019-10-30 [email protected] Roll src/third_party/skia 76d22d1ee8cb..1ae54bc22fc2 (26 commits) (flutter/engine#13430) 2019-10-30 [email protected] Roll src/third_party/dart ebd059030b..ae5a86d790 (3 commits) 2019-10-30 [email protected] Roll fuchsia/clang/linux-amd64 from Vghc_... to WxGHg... (flutter/engine#13420) 2019-10-30 [email protected] Roll fuchsia/sdk/core/mac-amd64 from mc3jR... to DfLN8... (flutter/engine#13413) 2019-10-30 [email protected] Roll src/third_party/dart 780af0fcfc..ebd059030b (17 commits) 2019-10-30 [email protected] Make sure root surface transformations survive resetting the matrix directly in Flow. (flutter/engine#13405) 2019-10-30 [email protected] [fuchsia] [packaging] Create a script to upload debug symbols to CIPD (flutter/engine#13422) 2019-10-29 [email protected] Revert "fix fml_unittes is not run during presubmit (#13395)" (flutter/engine#13425) 2019-10-29 [email protected] Made it so we clean up gl resources when view controllers get deleted. (flutter/engine#13396) 2019-10-29 [email protected] Added back in empty lifecycle events so we don't break people that used to call `super`. (flutter/engine#13421) 2019-10-29 [email protected] fix fml_unittes is not run during presubmit (flutter/engine#13395) 2019-10-29 [email protected] Roll src/third_party/skia f22dda960136..76d22d1ee8cb (2 commits) (flutter/engine#13411) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

[email protected]:flutter/engine.git/compare/36303c61b63f...5051bef git log 36303c6..5051bef --no-merges --oneline 2019-10-30 [email protected] Roll src/third_party/skia ebdae1144978..7da048b5e8f1 (1 commits) (flutter/engine#13438) 2019-10-30 [email protected] Roll fuchsia/sdk/core/mac-amd64 from DfLN8... to p7XYM... (flutter/engine#13437) 2019-10-30 [email protected] Roll src/third_party/dart eb4ab61349..d3a5b82355 (4 commits) 2019-10-30 [email protected] Roll fuchsia/sdk/core/linux-amd64 from goLxs... to nhX22... (flutter/engine#13435) 2019-10-30 [email protected] Roll src/third_party/skia c3a51a5e47ba..ebdae1144978 (1 commits) (flutter/engine#13434) 2019-10-30 [email protected] Roll src/third_party/skia 1ae54bc22fc2..c3a51a5e47ba (1 commits) (flutter/engine#13433) 2019-10-30 [email protected] Roll src/third_party/dart ae5a86d790..eb4ab61349 (7 commits) 2019-10-30 [email protected] Set the install name at link time for darwin dylibs (flutter/engine#13428) 2019-10-30 [email protected] Add isRunningInRobolectricTest back (flutter/engine#13424) 2019-10-30 [email protected] Roll src/third_party/skia 76d22d1ee8cb..1ae54bc22fc2 (26 commits) (flutter/engine#13430) 2019-10-30 [email protected] Roll src/third_party/dart ebd059030b..ae5a86d790 (3 commits) 2019-10-30 [email protected] Roll fuchsia/clang/linux-amd64 from Vghc_... to WxGHg... (flutter/engine#13420) 2019-10-30 [email protected] Roll fuchsia/sdk/core/mac-amd64 from mc3jR... to DfLN8... (flutter/engine#13413) 2019-10-30 [email protected] Roll src/third_party/dart 780af0fcfc..ebd059030b (17 commits) 2019-10-30 [email protected] Make sure root surface transformations survive resetting the matrix directly in Flow. (flutter/engine#13405) 2019-10-30 [email protected] [fuchsia] [packaging] Create a script to upload debug symbols to CIPD (flutter/engine#13422) 2019-10-29 [email protected] Revert "fix fml_unittes is not run during presubmit (flutter#13395)" (flutter/engine#13425) 2019-10-29 [email protected] Made it so we clean up gl resources when view controllers get deleted. (flutter/engine#13396) 2019-10-29 [email protected] Added back in empty lifecycle events so we don't break people that used to call `super`. (flutter/engine#13421) 2019-10-29 [email protected] fix fml_unittes is not run during presubmit (flutter/engine#13395) 2019-10-29 [email protected] Roll src/third_party/skia f22dda960136..76d22d1ee8cb (2 commits) (flutter/engine#13411) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

[fuchsia] [packaging] Create a script to upload debug symbols to CIPD

0bfd512

iskakaushik requested a review from chinmaygarde October 29, 2019 21:24

googlebot added the cla: yes label Oct 29, 2019

update recipe changelog

31b7444

iskakaushik requested review from gw280 and jason-simmons October 29, 2019 22:05

gw280 reviewed Oct 29, 2019

View reviewed changes

iskakaushik force-pushed the upload-debug-symbols-to-cipd branch from 6bcf241 to 39667a8 Compare October 29, 2019 23:47

fix typos

d2d3ba3

iskakaushik force-pushed the upload-debug-symbols-to-cipd branch from 39667a8 to d2d3ba3 Compare October 29, 2019 23:49

gw280 approved these changes Oct 29, 2019

View reviewed changes

iskakaushik merged commit 35f3104 into flutter:master Oct 30, 2019

iskakaushik deleted the upload-debug-symbols-to-cipd branch October 30, 2019 00:37

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2019

35f3104 [fuchsia] [packaging] Create a script to upload debug symbols…

4d5fd76

… to CIPD (flutter/engine#13422)

engine-flutter-autoroll mentioned this pull request Oct 30, 2019

Roll engine 36303c61b63f..5051bef17bdc (21 commits) flutter/flutter#43828

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fuchsia] [packaging] Create a script to upload debug symbols to CIPD#13422

[fuchsia] [packaging] Create a script to upload debug symbols to CIPD#13422
iskakaushik merged 3 commits intoflutter:masterfrom
iskakaushik:upload-debug-symbols-to-cipd

iskakaushik commented Oct 29, 2019

Uh oh!

gw280 Oct 29, 2019

Uh oh!

iskakaushik Oct 29, 2019

Uh oh!

gw280 Oct 29, 2019

Uh oh!

iskakaushik Oct 29, 2019

Uh oh!

gw280 Oct 29, 2019

Uh oh!

gw280 Oct 29, 2019

Uh oh!

iskakaushik Oct 29, 2019

Uh oh!

gw280 Oct 29, 2019

Uh oh!

iskakaushik Oct 29, 2019

Uh oh!

gw280 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		return temp_file


		def ProcessCIPDPakcage(upload, cipd_yaml, engine_version, out_dir, target_arch):

Conversation

iskakaushik commented Oct 29, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gw280 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants