This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Release shim bindings when detaching#13432
Merged
xster merged 1 commit intoflutter:masterfrom Nov 2, 2019
Merged
Conversation
matthew-carroll
approved these changes
Oct 30, 2019
Contributor
matthew-carroll
left a comment
matthew-carroll
left a comment
There was a problem hiding this comment.
LGTM. Is there still more investigation that needs to happen into the reported leak?
| } | ||
|
|
||
| pluginBinding = null; | ||
| activityPluginBinding = null; |
Contributor
There was a problem hiding this comment.
FYI, this isn't technically necessary because the engine will already be detached from the Activity before this executes.
Member
Author
There was a problem hiding this comment.
Discussed offline. Understood.
Though I'd keep them here since the current docs don't refer have the engine and activity callbacks refer to each other in terms of timing. So it would be a knowledge leak from the implementer side here to assume there is a sequence.
(though not a bad idea to actually add that to the javadoc, e.g. onDetachedFromEngine is guaranteed to call after all the ui component bindings had a chance to detach first and vice versa).
Member
Author
|
I couldn't repro the reported leak via leakcanary. I don't think there are further actions. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 5, 2019
[email protected]:flutter/engine.git/compare/0a8bd9dd6fbb...e73c9c8 git log 0a8bd9d..e73c9c8 --no-merges --oneline 2019-11-04 [email protected] Roll src/third_party/skia 8e083eee8ece..4cc2dc64ff13 (1 commits) (flutter/engine#13543) 2019-11-04 [email protected] Roll fuchsia/sdk/core/mac-amd64 from ggsQ5... to XcaoM... (flutter/engine#13535) 2019-11-04 [email protected] fix getBoxesForRange for zero-length ranges (flutter/engine#13483) 2019-11-04 [email protected] Roll src/third_party/dart bbe2ac28c9..ab5cf0f854 (73 commits) (flutter/engine#13614) 2019-11-02 [email protected] Roll src/third_party/skia 283ec65f632a..8e083eee8ece (32 commits) (flutter/engine#13489) 2019-11-02 [email protected] Roll fuchsia/sdk/core/mac-amd64 from FKqQ_... to ggsQ5... (flutter/engine#13490) 2019-11-02 [email protected] Release shim bindings when detaching (flutter/engine#13432) 2019-11-01 [email protected] Add fuchsia.intl.PropertyProvider to our services on Fuchsia (flutter/engine#13486) 2019-11-01 [email protected] [dart] Makes the intl services available (flutter/engine#13460) 2019-11-01 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 866GG... to dhwMR... (flutter/engine#13475) 2019-11-01 [email protected] Roll fuchsia/sdk/core/mac-amd64 from JngMB... to FKqQ_... (flutter/engine#13477) 2019-11-01 [email protected] Roll src/third_party/skia 809ec77893be..283ec65f632a (14 commits) (flutter/engine#13472) 2019-11-01 [email protected] Request a reattach when creating the text input plugin on Android (flutter/engine#13474) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/0a8bd9dd6fbb...e73c9c8 git log 0a8bd9d..e73c9c8 --no-merges --oneline 2019-11-04 [email protected] Roll src/third_party/skia 8e083eee8ece..4cc2dc64ff13 (1 commits) (flutter/engine#13543) 2019-11-04 [email protected] Roll fuchsia/sdk/core/mac-amd64 from ggsQ5... to XcaoM... (flutter/engine#13535) 2019-11-04 [email protected] fix getBoxesForRange for zero-length ranges (flutter/engine#13483) 2019-11-04 [email protected] Roll src/third_party/dart bbe2ac28c9..ab5cf0f854 (73 commits) (flutter/engine#13614) 2019-11-02 [email protected] Roll src/third_party/skia 283ec65f632a..8e083eee8ece (32 commits) (flutter/engine#13489) 2019-11-02 [email protected] Roll fuchsia/sdk/core/mac-amd64 from FKqQ_... to ggsQ5... (flutter/engine#13490) 2019-11-02 [email protected] Release shim bindings when detaching (flutter/engine#13432) 2019-11-01 [email protected] Add fuchsia.intl.PropertyProvider to our services on Fuchsia (flutter/engine#13486) 2019-11-01 [email protected] [dart] Makes the intl services available (flutter/engine#13460) 2019-11-01 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 866GG... to dhwMR... (flutter/engine#13475) 2019-11-01 [email protected] Roll fuchsia/sdk/core/mac-amd64 from JngMB... to FKqQ_... (flutter/engine#13477) 2019-11-01 [email protected] Roll src/third_party/skia 809ec77893be..283ec65f632a (14 commits) (flutter/engine#13472) 2019-11-01 [email protected] Request a reattach when creating the text input plugin on Android (flutter/engine#13474) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter/flutter#36898 doesn't repro, but there's a conceptual leak nevertheless where the shim registry and registrar hold onto bindings (which holds onto a bunch of other stuff) after detaching.