This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Request a reattach when creating the text input plugin on Android#13474
Merged
dnfield merged 3 commits intoflutter:masterfrom Nov 1, 2019
Merged
Request a reattach when creating the text input plugin on Android#13474dnfield merged 3 commits intoflutter:masterfrom
dnfield merged 3 commits intoflutter:masterfrom
Conversation
dnfield
added a commit
to dnfield/flutter
that referenced
this pull request
Nov 1, 2019
9 tasks
xster
approved these changes
Nov 1, 2019
dnfield
added
the
waiting for tree to go green
matthew-carroll
approved these changes
Nov 1, 2019
Contributor
matthew-carroll
left a comment
matthew-carroll
left a comment
There was a problem hiding this comment.
LGTM. Left a comment about a name change.
| * to a {@link FlutterEngine}, as the engine may have kept alive a text | ||
| * editing client on the Dart side. | ||
| */ | ||
| public void reattach() { |
Contributor
There was a problem hiding this comment.
Would it make sense to call this something like requestExistingInputState() instead, so that we remove the implicit temporal relationship and clarify why we call it?
Member
There may be an overflow happening, another lifecycle event before receiving the resumed event? It should print to the terminal when messages are dropped. The queues are all size 1 right now. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 5, 2019
[email protected]:flutter/engine.git/compare/0a8bd9dd6fbb...e73c9c8 git log 0a8bd9d..e73c9c8 --no-merges --oneline 2019-11-04 [email protected] Roll src/third_party/skia 8e083eee8ece..4cc2dc64ff13 (1 commits) (flutter/engine#13543) 2019-11-04 [email protected] Roll fuchsia/sdk/core/mac-amd64 from ggsQ5... to XcaoM... (flutter/engine#13535) 2019-11-04 [email protected] fix getBoxesForRange for zero-length ranges (flutter/engine#13483) 2019-11-04 [email protected] Roll src/third_party/dart bbe2ac28c9..ab5cf0f854 (73 commits) (flutter/engine#13614) 2019-11-02 [email protected] Roll src/third_party/skia 283ec65f632a..8e083eee8ece (32 commits) (flutter/engine#13489) 2019-11-02 [email protected] Roll fuchsia/sdk/core/mac-amd64 from FKqQ_... to ggsQ5... (flutter/engine#13490) 2019-11-02 [email protected] Release shim bindings when detaching (flutter/engine#13432) 2019-11-01 [email protected] Add fuchsia.intl.PropertyProvider to our services on Fuchsia (flutter/engine#13486) 2019-11-01 [email protected] [dart] Makes the intl services available (flutter/engine#13460) 2019-11-01 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 866GG... to dhwMR... (flutter/engine#13475) 2019-11-01 [email protected] Roll fuchsia/sdk/core/mac-amd64 from JngMB... to FKqQ_... (flutter/engine#13477) 2019-11-01 [email protected] Roll src/third_party/skia 809ec77893be..283ec65f632a (14 commits) (flutter/engine#13472) 2019-11-01 [email protected] Request a reattach when creating the text input plugin on Android (flutter/engine#13474) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/0a8bd9dd6fbb...e73c9c8 git log 0a8bd9d..e73c9c8 --no-merges --oneline 2019-11-04 [email protected] Roll src/third_party/skia 8e083eee8ece..4cc2dc64ff13 (1 commits) (flutter/engine#13543) 2019-11-04 [email protected] Roll fuchsia/sdk/core/mac-amd64 from ggsQ5... to XcaoM... (flutter/engine#13535) 2019-11-04 [email protected] fix getBoxesForRange for zero-length ranges (flutter/engine#13483) 2019-11-04 [email protected] Roll src/third_party/dart bbe2ac28c9..ab5cf0f854 (73 commits) (flutter/engine#13614) 2019-11-02 [email protected] Roll src/third_party/skia 283ec65f632a..8e083eee8ece (32 commits) (flutter/engine#13489) 2019-11-02 [email protected] Roll fuchsia/sdk/core/mac-amd64 from FKqQ_... to ggsQ5... (flutter/engine#13490) 2019-11-02 [email protected] Release shim bindings when detaching (flutter/engine#13432) 2019-11-01 [email protected] Add fuchsia.intl.PropertyProvider to our services on Fuchsia (flutter/engine#13486) 2019-11-01 [email protected] [dart] Makes the intl services available (flutter/engine#13460) 2019-11-01 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 866GG... to dhwMR... (flutter/engine#13475) 2019-11-01 [email protected] Roll fuchsia/sdk/core/mac-amd64 from JngMB... to FKqQ_... (flutter/engine#13477) 2019-11-01 [email protected] Roll src/third_party/skia 809ec77893be..283ec65f632a (14 commits) (flutter/engine#13472) 2019-11-01 [email protected] Request a reattach when creating the text input plugin on Android (flutter/engine#13474) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engine side of a fix for flutter/flutter#35054
If the view heirarchy was torn down, for example because the app was backgrounded and detached from the FlutterEngine instance, the embedder loses all knowledge of text input clients from the framework. However, the framework can maintain these client(s) if the engine is preserved. When the view is reattached, it needs to be re-informed of such clients. Another PR will be opened in the framework to respond to this message.
We can't use
AppLifecycleState.resumed, because it comes too early (Dart code receives it before the FlutterView has re-attached to the engine, and has no way of knowing when it's safe to re-send the message). @gaaclarke - I thought maybe the Channel Buffers stuff would handle that but apparently it's not. We can discuss more if that's unexpected./cc @dannyvalentesonos