This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Temporarily disable intl provider#13696
Merged
iskakaushik merged 1 commit intoflutter:masterfrom Nov 6, 2019
Merged
Conversation
filmil
force-pushed
the
temporarily-disable-intl-provider
branch
from
c0a4f82 to
33ba6d5
Compare
The intention of the property provider is to try to connect, not bail out if connection is not possible. This code tried to connect unconditionally, which is not what we wanted. Removing this initialization code to enable a roll, and will fix in a followup.
filmil
force-pushed
the
temporarily-disable-intl-provider
branch
from
33ba6d5 to
9e30517
Compare
Contributor
|
Landing this to make the roll easier. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 6, 2019
[email protected]:flutter/engine.git/compare/05ab04dbe8cf...6c763bb git log 05ab04d..6c763bb --no-merges --oneline 2019-11-06 [email protected] [fuchsia] Temporarily disable intl provider (flutter/engine#13696) 2019-11-05 [email protected] Fix plugin registrant reflection path. (#44161) (flutter/engine#13698) 2019-11-05 [email protected] Added Semantic header support on Android. (flutter/engine#13262) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
filmil
added a commit
to filmil/engine
that referenced
this pull request
Nov 6, 2019
This reverts commit 6c763bb. The reverted code was not the root cause of the issues with rolling flutter into fuchsia, so adding it back. In addition, lowering the severity of the connection error at the outset to WARNING; since it is not a hard failure.
iskakaushik
pushed a commit
that referenced
this pull request
Nov 9, 2019
This reverts commit 6c763bb. The reverted code was not the root cause of the issues with rolling flutter into fuchsia, so adding it back. In addition, lowering the severity of the connection error at the outset to WARNING; since it is not a hard failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention of the property provider is to try to connect, not
bail out if connection is not possible.
This code tried to connect unconditionally, which is not what we wanted.
Removing this initialization code to enable a roll, and will fix in a
followup.