Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix RendererContextSwitch result check in Rasterizer::MakeRasterSnapshot#13785

Merged
jason-simmons merged 1 commit intoflutter:masterfrom
jason-simmons:bug_31355
Nov 11, 2019
Merged

Fix RendererContextSwitch result check in Rasterizer::MakeRasterSnapshot#13785
jason-simmons merged 1 commit intoflutter:masterfrom
jason-simmons:bug_31355

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Nov 11, 2019

@cyanglaz
Copy link
Contributor

cyanglaz commented Nov 11, 2019

LGTM!

@jason-simmons jason-simmons merged commit ce0e9e7 into flutter:master Nov 11, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
2a7fe7a 
…terSnapshot (flutter/engine#13785)
This was referenced Nov 12, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
20ce99e 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
03b1acd 
…terSnapshot (flutter/engine#13785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
9194b84 
…terSnapshot (flutter/engine#13785)
This was referenced Nov 12, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
4684359 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
40a7c70 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
5043c0f 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
bafede0 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
2da7095 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
dbe42ec 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
86a9559 
…terSnapshot (flutter/engine#13785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
6812edf 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
a9c3c80 
…terSnapshot (flutter/engine#13785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
b458727 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
c82c363 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
eb9c54a 
…terSnapshot (flutter/engine#13785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
5cec5bd 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
776e531 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
b842a84 
…terSnapshot (flutter/engine#13785)
This was referenced Nov 12, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
fe3ab9e 
…terSnapshot (flutter/engine#13785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
c049c80 
…terSnapshot (flutter/engine#13785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
ce0e9e7 Fix RendererContextSwitch result check in Rasterizer::MakeRas…
7f1c6a6 
…terSnapshot (flutter/engine#13785)
This was referenced Nov 12, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@GaryQian GaryQian mentioned this pull request Nov 13, 2019
Merged
This was referenced Nov 13, 2019
Closed
Closed
Closed
Closed
Closed
@liyuqian liyuqian mentioned this pull request Feb 25, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash in ShaderWarmUp.execute()

3 participants

@jason-simmons @cyanglaz @googlebot