This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Do not default to downstream affinity on iOS insertText#13852
Merged
GaryQian merged 3 commits intoflutter:masterfrom Nov 22, 2019
Merged
Do not default to downstream affinity on iOS insertText#13852GaryQian merged 3 commits intoflutter:masterfrom
GaryQian merged 3 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
This allows flutter/flutter#44622 to work for iOS |
Contributor
Author
|
Still tuning exactly which calls should get ambiguous affinity |
Contributor
Author
|
flutter/flutter#44622 should be landed first for this to work. |
justinmc
approved these changes
Nov 18, 2019
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM as long as the framework PR works (flutter/flutter#44622).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2019
GaryQian
added a commit
that referenced
this pull request
Nov 27, 2019
…)" This reverts commit 0d60e1a.
GaryQian
added a commit
that referenced
this pull request
Nov 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the framework to fall back on LibTxt metrics when the affinity is ambiguous.