This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix withIn matcher distance function lookup#13904
Merged
ferhatb merged 2 commits intoflutter:masterfrom Nov 19, 2019
Merged
Conversation
| throw ArgumentError( | ||
| 'The specified distanceFunction was null, and a standard distance ' | ||
| 'function was not found for type ${from.runtimeType} of the provided ' | ||
| 'function was not found for type ${T} of the provided ' |
Contributor
There was a problem hiding this comment.
extreme nit: you can remove the curly braces
harryterkelsen
approved these changes
Nov 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 19, 2019
[email protected]:flutter/engine.git/compare/9832bc8f2eb2...762294c git log 9832bc8..762294c --no-merges --oneline 2019-11-19 [email protected] Revert "RendererContextSwitch guard flutter's gl context rework. (#13812)" (flutter/engine#13906) 2019-11-19 [email protected] Roll src/third_party/dart 06e6554d2e..830f291773 (22 commits) (flutter/engine#13905) 2019-11-19 [email protected] Fix withIn matcher distance function lookup (flutter/engine#13904) 2019-11-18 [email protected] Roll src/third_party/dart aceeba7567..06e6554d2e (2 commits) (flutter/engine#13900) 2019-11-18 [email protected] Fix single line bitmap canvas text shadow (flutter/engine#13901) 2019-11-18 [email protected] Roll fuchsia/sdk/core/linux-amd64 from dhwMR... to kSMF7... (flutter/engine#13899) 2019-11-18 [email protected] Roll src/third_party/dart 7b67303318..aceeba7567 (8 commits) 2019-11-18 [email protected] Roll fuchsia/sdk/core/mac-amd64 from 6ZRA_... to Oo6E_... (flutter/engine#13894) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
expect(contourLengths[1], within(distance: kTolerance, from: 100.0));
This currently fails with withIn using .runtimeType as int. This fix uses the inferred type using parameter type T to correctly generate closure.