This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
dnfield
requested review from
goderbauer,
gspencergoog,
jonahwilliams and
matthew-carroll
and removed request for
GaryQian
gspencergoog
approved these changes
Dec 2, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 3, 2019
Contributor
|
FYI - it looks like PR is missing tests. |
Contributor
Author
|
Yes. We have no good way to test this unfortunately other than manually. We'd have to try to capture the output of TalkBack on a real device to test this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#45930
We're currently only allow the live region announcement to process if the liveRegion flag has changed. This works fine for a snackbar appearing once but not so well for e.g. a label that you want announced when it updates.
This also allows us to simplify the logic for text fields, since they use liveRegion when focused.
/cc @darrenaustin