This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rename 'test_vsync_waiters' to 'vsync_waiters_test' for consistency.#14519
Merged
GaryQian merged 2 commits intoflutter:masterfrom Dec 17, 2019
Merged
Rename 'test_vsync_waiters' to 'vsync_waiters_test' for consistency.#14519GaryQian merged 2 commits intoflutter:masterfrom
GaryQian merged 2 commits intoflutter:masterfrom
Conversation
GaryQian
requested review from
chinmaygarde,
iskakaushik and
mehmetf
and removed request for
gaaclarke
GaryQian
changed the title
gaaclarke
approved these changes
Dec 17, 2019
|
|
||
| #ifndef FLUTTER_SHELL_COMMON_TEST_VSYNC_WAITERS_H_ | ||
| #define FLUTTER_SHELL_COMMON_TEST_VSYNC_WAITERS_H_ | ||
| #ifndef FLUTTER_SHELL_COMMON_VSYNC_WAITERS_TEST_H_ |
Member
There was a problem hiding this comment.
Don't we typically use the "*_test.cc" filename for things with tests in them?
Contributor
Author
There was a problem hiding this comment.
Yes, that is what this PR is changing it to.
Contributor
Author
|
Luci failure seems to be a flake (as of now). |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
This was referenced Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
This was referenced Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
chingjun
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 18, 2019
* ee92285 Roll src/third_party/skia fdb2b7d53038..cbeabd969bbe (1 commits) (flutter/engine#14530) * 9b369ad Rename 'test_vsync_waiters' to 'vsync_waiters_test' for consistency. (flutter/engine#14519) * 0f97a1e Roll src/third_party/skia cbeabd969bbe..3794db84e141 (8 commits) (flutter/engine#14532) * ac42640 Roll src/third_party/dart f10fa3df28a8..44da51fc720d (20 commits) (flutter/engine#14533) * c216ba4 Calling onConnectionClosed when the input element is blurred (flutter/engine#14484) * 44f0757 Manual roll of Dart to revision 8a4cac1ddb141d4a1e395f6e0a7d5bbf2247eb63 (flutter/engine#14542) * 995c4a7 Roll src/third_party/dart 8a4cac1ddb14..b6e051e2c87a (2 commits) (flutter/engine#14545) * c568308 Roll src/third_party/skia 190b82d67ce1..37a88b43637e (1 commits) (flutter/engine#14546) * c327cae Revert "Fix off-by-one fromRGBO alpha value calculation (#13777)" (flutter/engine#14548)
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should maintain the same format of test naming. This follows what exists already in the repo.
This will smooth out the g3 roll as well, eliminating need for explicit copy.bara.sky exclusions.