This repository was archived by the owner on Feb 25, 2025. It is now read-only.
startup flags use startup recorder#14568
Closed
yuanhuihui wants to merge 5 commits intoflutter:masterfrom
Closed
Conversation
Contributor
|
Unfortunately, this changes existing behavior. If the startup flag is not combined with the endless trace flag, the startup traces are almost always lost which is not what we want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we set FLAG_startup_timeline, using TimelineEventStartupRecorder.
If we set FLAG_systrace_timeline, using TimelineEventSystraceRecorder.
If set use_endless_recorder, using TimelineEventEndlessRecorder.
in file third_party/dart/runtime/vm/timeline.cc
So we set trace_startup should be equivalent to FLAG_startup_timeline, instead of using endless recorder. If needed, we can combine two parameters, such as: flutter run --trace-startup --endless-trace-buffer. That will use startup‘s streams and endless buffer.