Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

startup flags use startup recorder #14568

Closed
yuanhuihui wants to merge 5 commits into from
Closed

startup flags use startup recorder #14568

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f93724
fix timeline recorder
yuanhuihui Dec 19, 2019
e1a08ad
fix timeline
yuanhuihui Dec 19, 2019
57ac26f
Merge branch 'master' into fix_timeline_recorder
yuanhuihui Jan 10, 2020
6d5db99
resolve conflicts
yuanhuihui Feb 12, 2020
277c734
Merge remote-tracking branch 'upstream/master' into fix_timeline_reco…
yuanhuihui Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions runtime/dart_vm.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,14 @@ static const char* kDartDisableServiceAuthCodesArgs[]{
"--disable-service-auth-codes",
};

static const char* kDartTraceStartupArgs[]{
static const char* kDartTraceStartupStreamsArgs[]{
"--timeline_streams=Compiler,Dart,Debugger,Embedder,GC,Isolate,VM,API",
};

static const char* kDartStartupTraceBufferArgs[]{
"--timeline_recorder=startup",
};

static const char* kDartEndlessTraceBufferArgs[]{
"--timeline_recorder=endless",
};
Expand Down Expand Up @@ -353,11 +357,14 @@ DartVM::DartVM(std::shared_ptr<const DartVMData> vm_data,
fml::size(kDartDisableServiceAuthCodesArgs));
}

if (settings_.endless_trace_buffer || settings_.trace_startup) {
// If we are tracing startup, make sure the trace buffer is endless so we
// don't lose early traces.
PushBackAll(&args, kDartEndlessTraceBufferArgs,
fml::size(kDartEndlessTraceBufferArgs));
if (settings_.trace_startup) {
// If set trace_startup should be equivalent to FLAG_startup_timeline,
// instead of using endless recorder. If needed, we can combine two
// parameters. example: flutter run --trace-startup --endless-trace-buffer.
PushBackAll(&args, kDartStartupTraceBufferArgs,
fml::size(kDartStartupTraceBufferArgs));
PushBackAll(&args, kDartTraceStartupStreamsArgs,
fml::size(kDartTraceStartupStreamsArgs));
}

if (settings_.trace_systrace) {
Expand All @@ -366,8 +373,9 @@ DartVM::DartVM(std::shared_ptr<const DartVMData> vm_data,
PushBackAll(&args, kDartTraceStreamsArgs, fml::size(kDartTraceStreamsArgs));
}

if (settings_.trace_startup) {
PushBackAll(&args, kDartTraceStartupArgs, fml::size(kDartTraceStartupArgs));
if (settings_.endless_trace_buffer) {
PushBackAll(&args, kDartEndlessTraceBufferArgs,
fml::size(kDartEndlessTraceBufferArgs));
}

std::string old_gen_heap_size_args;
Expand Down