trivial dart-sdk update to trigger engine rebuild for flutter hotfix#16344
trivial dart-sdk update to trigger engine rebuild for flutter hotfix#16344tvolkert merged 2 commits intoflutter:v1.12.13-hotfixesfrom christopherfujino:v1.12.13-hotfixes
Conversation
…ld of the engine can be hotfixed into flutter stable v1.12.13.
|
The LUCI failures are because the engine recipe has changed since this release. When we land this, the post-submit builders will also fail, and I will have to manually re-run them setting a property to skip the |
|
Can you update https://github.com/flutter/engine/blob/master/tools/luci/force_luci_build.sh as needed (doesn't have to be, and probably shouldn't be, in this PR) to pass whatever flags make sense? |
Cool, I didn't know about that script. It wouldn't make sense to add the flag to ToT however, as it's not needed. I can add it to this hotfix, though, which will help if we need to hotfix this version again. |
|
@tvolkert I added the |
The last flutter stable hotfix was not codesigned. Thus, this PR is a trivial dart-sdk merge commit (no source changed) so that a new build of the engine can be hotfixed into flutter stable v1.12.13. Here is the diff between the two dart revisions https://github.com/dart-lang/sdk/compare/a4911c6..4cc3605