Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Set the current GL context to the most recently acquired Surface#16572

Merged
harryterkelsen merged 1 commit intoflutter:masterfrom
harryterkelsen:canvaskit-overlay-context
Feb 13, 2020
Merged

Set the current GL context to the most recently acquired Surface#16572
harryterkelsen merged 1 commit intoflutter:masterfrom
harryterkelsen:canvaskit-overlay-context

Conversation

@harryterkelsen
Copy link
Contributor

Fixes flutter/flutter#49947

Unfortunately, I can't find a way to share resources between GL contexts. But I also found that most errors of textures being bound in one context and used in another are caused by not setting the correct context.

@gaaclarke
Copy link
Member

I can't find a way to share resources between GL contexts.

In iOS GL they are called sharegroups (https://developer.apple.com/documentation/opengles/eaglcontext/1624878-sharegroup?language=objc), if you are talking WebGL looks there was a rejected extension: https://www.khronos.org/registry/webgl/extensions/rejected/WEBGL_shared_resources/

@harryterkelsen
Copy link
Contributor Author

Landing despite unrelated error in the Fuchsia build bot

@harryterkelsen harryterkelsen merged commit 22d08d1 into flutter:master Feb 13, 2020
dnfield added a commit to flutter/flutter that referenced this pull request Feb 14, 2020
flutter/engine@d60f298 Manual roll of Dart 0299903f3e...edd64e6d5c (flutter/engine#16604)
flutter/engine@22d08d1 Set the current GL context to the most recently acquired Surface (flutter/engine#16572)
flutter/engine@c210c3d Roll src/third_party/skia 3bf3b92dfab0..55f040bcb943 (3 commits) (flutter/engine#16587)
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Web] [CanvasKit] WebGL errors when using HtmlElementView

4 participants