This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Skipping failing edge tests#16626
Merged
nturgut merged 4 commits intoflutter:masterfrom Feb 18, 2020
Merged
Conversation
added 2 commits
February 14, 2020 12:57
…ll) for methods failing on edge
harryterkelsen
approved these changes
Feb 14, 2020
Contributor
Author
|
Merging the PR since it only affect the web engine running Edge+Windows. Fuschia tests are unrelated to the change. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 19, 2020
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
* making edge default test browser on windows. adding some skips (not all) for methods failing on edge * skip failing tests. make egde default for testing * skip one more test * addressing reviewer comments. removing extra bat file
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This reverts commit 4964705.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip failing test methods on Edge. make Egde default for testing on windows. (I only changed the windows bat file so this won't effect other cirrus/LUCI tests in anyway)
the skipped tests are added to this project: https://github.com/flutter/flutter/projects/114
The Edge tests will start running on LUCI, the results can be seen under: Windows Web Engine